Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#998 closed defect (fixed)

Fix problems with unselected list items

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: blocker Milestone: Reggie v4.11.3
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

See http://base.thep.lu.se/ticket/2096 for some background information about using new Option() in javascript with 3 parameters.

It turns out that Reggie is using the 3-parameter variant in some places and the 4-parameter variant in other places. It is expected that problems may arise due to this. In the best case it is just an annoyance forcing the user to manually select items. In the worst case things may stop working in some wizards (there was an earlier report about this a few weeks ago).

Change History (4)

comment:1 Changed 2 years ago by Nicklas Nordborg

Milestone: Reggie v4.xReggie v4.11.3
Status: newassigned

comment:2 Changed 2 years ago by Nicklas Nordborg

Priority: criticalblocker

The following wizards do not work at all:

  • Lab protocols for pooling: The protocols are empty
  • Register pooled libraries: Error message "Select at least one pool" is displayed, but the selection list is disabled

There are several other wizards were default options (default protocol, default software, etc.) are not automatically selected. This may cause incorrect information to be registered in case the user is no changing to the correct option.

comment:3 Changed 2 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [4583]) Fixes #998: Fix problems with unselected list items

The problem was found in the wizards listed below. Unless otherwise noted, manual selection could be used to select the correct option. In most places the selection list contained only one option or the first option was the same as the default so the problem would pass by without notice.

The problem only affected functionality in the two pooling wizards. The only known workaround is to use Firefox version 54 or earlier.

  • Start Tophat and Cufflinks
    • Default array design not selected
    • Default job priority not selected
  • Start demux and merge
    • Default job priority not selected
  • Create flow cells
    • Pools not selected
  • Lab protocols for pooling
    • Pools not selected (manual selection not possible)
  • Register pooled libraries
    • Pools not selected (manual selection not possible)
  • Register sequencing started
    • Flow cell not selected
    • Default job priority not selected
  • Partition wizard
    • Specimen with locally stored information not selected
  • Create aliquots on Bioanalyzer/Caliper? plates
    • Existing bioplate always selects the first one (even if there is not enough free wells)
  • Several wizards
    • Default protocol not selected
    • Default software not selected
    • Default hardware not selected

comment:4 Changed 2 years ago by Nicklas Nordborg

(In [4585]) References #998: Fix problems with unselected list items

Applying same change as [4583] to the 4.11-stable branch.

Note: See TracTickets for help on using tickets.