Is the copyright engine adding extra new lines to the end of a file if there is none?

[Jari Häkkinen]

See ​http://base.thep.lu.se/ticket/737 where it is reported that extra lines have been added after running the copyright part of svndigest.

[Peter Johansson]

at source:trunk/lib/File.cc#L359​ there is following code

 while(getline(is, line))
   tmp << line << "\n";

where tmp is an ostream.

So the answer is yes. If last character is not a newline, function will add a newline.

[Jari Häkkinen]

Ok, so we need to change this. The code clearly adds a new line character, but what about users with microsoft based new lines, i.e., new line with a carriage return?

[Peter Johansson]

We have OS dependent code elsewhere so why be MS friendly in this particular case.

[Peter Johansson]

This ticket interfere with tickets #231 #232 and #247, which are implemented in trunk.

Either we need to merge these implementations to stable-0.6 branch or move this ticket to 0.7 (i.e. trunk).

What do you think?

[Peter Johansson]

After some fresh air, I realize my last comment was surprisingly stupid.

I will solve this within 0.6. If there is a conflict, I'll simply solve the confict...

[Peter Johansson]

in [470]