Opened 13 years ago

Closed 13 years ago

#281 closed defect (fixed)

exit gracefully when ROOT is not a working copy

Reported by: Peter Johansson Owned by: Jari Häkkinen
Priority: major Milestone: svndigest 0.6.5
Component: core Version: trunk
Keywords: Cc:

Description

I get the following error message.

$ svndigest -v
Done parsing parameters
Initializing SVN singleton.
svndigest: '/home/peter' is not a working copy
svndigest: Can't open file '/home/peter/.svn/entries': No such file or directory
*** glibc detected *** svndigest: double free or corruption (!prev): 0x09a8b9c8 ***

Change History (3)

comment:1 Changed 13 years ago by Peter Johansson

Milestone: 0.70.6.5
Type: enhancementdefect

comment:2 Changed 13 years ago by Peter Johansson

(In [572]) Fixed double deletion by removing call to apr_allocator_destroy(allocator_);.

Having both apr_allocator_destroy or svn_pool_destroy caused double deletion. Removing one of them solved the issue. I could not find any call to apr_allocator_destroy in subversion::main, so I hope the remove does not cause a memory leak.

Currently if the --root is not a wc, the output is

svndigest: '/home/peter/FOO' is not a working copy
svndigest: Can't open file '/home/peter/FOO/.svn/entries': No such file or directory

svndigest: SVN: svn_wc_adm_open3 failed
svndigest: failed to initilize subversion access for /home/peter/FOO

I would prefer to

svndigest: '/home/peter/FOO' is not a working copy

or at least remove the empty line and embrace last path with (giving 'path').

Therefore I leave this ticket open.

comment:3 Changed 13 years ago by Peter Johansson

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.