Opened 14 years ago

Closed 14 years ago

#213 closed request (fixed)

should we remove minmax_index

Reported by: Peter Owned by: Jari Häkkinen
Priority: trivial Milestone: yat 0.3 (Public release)
Component: utility Version: trunk
Keywords: Cc:

Description

implemented here

http://lev.thep.lu.se/trac/yat/browser/trunk/yat/utility/utility.cc#L95

If you wanna keep it I suggest we remove the variable subset because it not inline with present design. We have DataLookup1D to take care of subset of vectors.

Also I think the function should be templatized to allow DataLookup1D as well as std::vector.

Also, I think it bad style returning a pair. When wanna return two variables I prefer doing it by passing two references.

Again, if this function is not used I think we could remove it.

Change History (2)

comment:1 Changed 14 years ago by Jari Häkkinen

Well, the issue should be easy to resolve. You introduced it, you may remove it.

comment:2 Changed 14 years ago by Peter

Resolution: fixed
Status: newclosed

ChangeSet? [825] removed minmax functions and moved shuffle into vector.*

Note: See TracTickets for help on using tickets.