Opened 12 years ago

Closed 12 years ago

#466 closed enhancement (fixed)

Add interface to GSL interpolation functionality

Reported by: Jari Häkkinen Owned by: Jari Häkkinen
Priority: major Milestone: yat 0.5
Component: regression Version: trunk
Keywords: Cc:

Description (last modified by Jari Häkkinen)

http://www.gnu.org/software/gsl/manual/html_node/Interpolation.html

The GSLInterpolation class should throw GSL_error not gsl_status.

Change History (19)

comment:1 Changed 12 years ago by Jari Häkkinen

(In [1643]) Addresses #466 and #425. Added cubic spline interpolation (not complete interface to GSL interpolation stuff).

comment:2 Changed 12 years ago by Jari Häkkinen

Status: newassigned

comment:3 Changed 12 years ago by Jari Häkkinen

(In [1644]) Addresses #466. Changed to VectorBase? passing. Added documentation.

comment:4 Changed 12 years ago by Jari Häkkinen

(In [1645]) Addresses #466. Changed name of CSpline to CSplineInterpolation.

comment:5 Changed 12 years ago by Jari Häkkinen

(In [1646]) Addresses #466 added linear interpolation classes.

comment:6 Changed 12 years ago by Jari Häkkinen

(In [1647]) Addresses #466. Added more interpolation algorithms. The full set of GSL 1.11 interpolation methods is now interfaced.

comment:7 Changed 12 years ago by Jari Häkkinen

(In [1648]) Addresses #466. Added more GSL functionality, added constructor tests.

comment:8 Changed 12 years ago by Jari Häkkinen

More tests are needed before closing this ticket.

comment:9 in reply to:  6 ; Changed 12 years ago by Peter

Replying to jari:

(In [1647]) Addresses #466. Added more interpolation algorithms. The full set of GSL 1.11 interpolation methods is now interfaced.

Hm, this comment was a bit misleading. Does yat require GSL 1.11? No, I successfully compiled against GSL 1.10. So what is really required? Is GSL 1.8 still sufficient or do we need to update configure and documentation?

comment:10 in reply to:  9 ; Changed 12 years ago by Jari Häkkinen

Replying to peter:

Replying to jari:

(In [1647]) Addresses #466. Added more interpolation algorithms. The full set of GSL 1.11 interpolation methods is now interfaced.

Hm, this comment was a bit misleading. Does yat require GSL 1.11? No, I successfully compiled against GSL 1.10. So what is really required? Is GSL 1.8 still sufficient or do we need to update configure and documentation?

It may be misleading but I do not state that 1.11 is required, and this was by purpose. It was meant to say that if you use 1.11 you will not have any problems. I based my coding on GSL 1.11, and you have now tested 1.10. Being lazy and I prefer not to dig up 1.8 docs to verify that 1.8 has the same interpolation interface as 1.10 the easy option is to require 1.10.

comment:11 in reply to:  10 Changed 12 years ago by Peter

Replying to jari:

Replying to peter:

Replying to jari:

(In [1647]) Addresses #466. Added more interpolation algorithms. The full set of GSL 1.11 interpolation methods is now interfaced.

Hm, this comment was a bit misleading. Does yat require GSL 1.11? No, I successfully compiled against GSL 1.10. So what is really required? Is GSL 1.8 still sufficient or do we need to update configure and documentation?

It may be misleading but I do not state that 1.11 is required, and this was by purpose. It was meant to say that if you use 1.11 you will not have any problems. I based my coding on GSL 1.11, and you have now tested 1.10. Being lazy and I prefer not to dig up 1.8 docs to verify that 1.8 has the same interpolation interface as 1.10 the easy option is to require 1.10.

Yes, your statement is, of course, correct. I checked the NEWS file in GSL and AFAICS there is no change in interpolation functions (except some bug fixes) after GSL 1.1, so I think we could stay with requirement GSL 1.8.

comment:12 Changed 12 years ago by Jari Häkkinen

(In [1655]) Addresses #466. Removed bsearch from the GSL wrapper.

comment:13 Changed 12 years ago by Peter

(In [1661]) refs #466: moved destructor to be (pure) virtual and public.

comment:14 in reply to:  13 ; Changed 12 years ago by Peter

Replying to peter:

(In [1661]) refs #466: moved destructor to be (pure) virtual and public.

Shall we move constructor as well?

comment:15 in reply to:  14 Changed 12 years ago by Jari Häkkinen

Replying to peter:

Replying to peter:

(In [1661]) refs #466: moved destructor to be (pure) virtual and public.

Shall we move constructor as well?

Sure.

comment:16 Changed 12 years ago by Peter

(In [1663]) typos in Makefile.am - refs #466

comment:17 Changed 12 years ago by Jari Häkkinen

Description: modified (diff)

comment:18 Changed 12 years ago by Jari Häkkinen

(In [1722]) Addresses #466. Moved default contructor to be public.

comment:19 Changed 12 years ago by Jari Häkkinen

Resolution: fixed
Status: assignedclosed

(In [1724]) Fixes #466. GSL_error is now thrown on GSL errors. Last thing in this ticket.

Note: See TracTickets for help on using tickets.