Changeset 3078

Timestamp:

Jan 22, 2007, 2:51:17 PM (16 years ago)

Author:

Nicklas Nordborg

Message:

References #459: Better error message if plugin jar can't be found

Throw InvalidDataException? instead of IOException to make the web application display a simple
error message instead of a complete stack trace.

Location:

trunk/src/core/net/sf/basedb

Files:

• core/PluginDefinition.java (modified) (2 diffs)
• util/JarClassLoader.java (modified) (3 diffs)

trunk/src/core/net/sf/basedb/core/PluginDefinition.java

@@ -39 +39 @@
 import net.sf.basedb.util.JarClassLoader;
 
-import java.io.IOException;
 import java.util.Collection;
 import java.util.Collections;
@@ -981 +980 @@
       return (Plugin)c.newInstance();
     }
-    catch (IOException ioex)
-    {
-      throw new BaseException(ioex);
+    catch (BaseException bex)
+    {
+      throw bex;
     }
     catch (Exception ex)

trunk/src/core/net/sf/basedb/util/JarClassLoader.java

@@ -37 +37 @@
 import java.net.MalformedURLException;
 
+import net.sf.basedb.core.InvalidDataException;
+
 /**
   A class loader implementation that loads classes from JAR files.
@@ -134 +136 @@
     Create a new JAR file class loader.
     @param jarPath The path to the JAR file
-    @throws IOException If the JAR file can't be loaded
+    @throws InvalidDataException If the JAR file can't be loaded
+    @throws IOException If there is another IO-related error
   */
   private JarClassLoader(String jarPath)
@@ -141 +144 @@
     super(Thread.currentThread().getContextClassLoader());
     mainJarFile = new File(jarPath);
-    if (!mainJarFile.exists()) throw new IOException("Couldn't find jar-file: \"" + jarPath + "\"");
+    if (!mainJarFile.exists()) throw new InvalidDataException("JAR file not found: " + jarPath);
     classPath = new HashMap<String, File>();
     loadJarFile(mainJarFile, true);