Changeset 3574

Timestamp:

Jul 19, 2007, 12:31:38 PM (16 years ago)

Author:

Nicklas Nordborg

Message:

References #658: Compare requestId as strings instead of integers to avoid problem with integer conversion (see #688)

File:

• trunk/www/common/plugin/index.jsp (modified) (1 diff)

trunk/www/common/plugin/index.jsp

@@ -328 +328 @@
   {
     int maxRecent = Base.getMaxRecent(sc);
-    PluginConfigurationRequest pcRequest = (PluginConfigurationRequest)sc.getSessionSetting("plugin.configure.request");
-    int requestId = Values.getInt(request.getParameter("requestId"), System.identityHashCode(pcRequest));
-    if (requestId != System.identityHashCode(pcRequest))
+    PluginConfigurationRequest pcRequest = (PluginConfigurationRequest)sc.getSessionSetting("plugin.configure.request");    
+    String requestId = request.getParameter("requestId");
+    if (requestId != null && !requestId.equals(Integer.toString(System.identityHashCode(pcRequest))))
     {
       throw new WebException("popup", "Invalid request ID", "Data in your configuration wizard has become corrupted. Please re-start and try again.");