Changeset 3574


Ignore:
Timestamp:
Jul 19, 2007, 12:31:38 PM (14 years ago)
Author:
Nicklas Nordborg
Message:

References #658: Compare requestId as strings instead of integers to avoid problem with integer conversion (see #688)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/www/common/plugin/index.jsp

    r3559 r3574  
    328328  {
    329329    int maxRecent = Base.getMaxRecent(sc);
    330     PluginConfigurationRequest pcRequest = (PluginConfigurationRequest)sc.getSessionSetting("plugin.configure.request");
    331     int requestId = Values.getInt(request.getParameter("requestId"), System.identityHashCode(pcRequest));
    332     if (requestId != System.identityHashCode(pcRequest))
     330    PluginConfigurationRequest pcRequest = (PluginConfigurationRequest)sc.getSessionSetting("plugin.configure.request");   
     331    String requestId = request.getParameter("requestId");
     332    if (requestId != null && !requestId.equals(Integer.toString(System.identityHashCode(pcRequest))))
    333333    {
    334334      throw new WebException("popup", "Invalid request ID", "Data in your configuration wizard has become corrupted. Please re-start and try again.");
Note: See TracChangeset for help on using the changeset viewer.