Changeset 3644

Timestamp:

Aug 8, 2007, 2:45:36 PM (16 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #716: Plugin configuration import should be able ot set the permission on the imported configurations to the same as the plug-in itself

File:

• trunk/src/plugins/core/net/sf/basedb/plugins/PluginConfigurationImporter.java (modified) (6 diffs)

trunk/src/plugins/core/net/sf/basedb/plugins/PluginConfigurationImporter.java

@@ -112 +112 @@
       "The XML-file to import the configuration parameters from",
       new FileParameterType(null, true, 1));
-  
+  private static final PluginParameter<Boolean> setPermissionsParameter = 
+    new PluginParameter<Boolean>(
+      "setPermissions",
+      "Inherit shared permissions",
+      "Select if the new configurations should be shared to the same users, " +
+      "groups and projects as the plug-in they belong to. If FALSE, the new configurations " +
+      "will not be shared.",
+      new BooleanParameterType(true, true)
+    );
   
   private RequestInformation configureJob;
@@ -118 +126 @@
   // Variables to store the job parameters in.
   private File xmlFile;
+  private boolean setPermissions;
 
   /*
@@ -167 +176 @@
       }
       storeValue(job, request, xmlFileParameter);
+      storeValue(job, request, setPermissionsParameter);
       response.setDone("The job configuration is complete");      
     }   
@@ -204 +214 @@
       {
         xmlFile = (File)job.getValue("xmlfile");
+        setPermissions = Boolean.TRUE.equals(job.getValue("setPermissions")); 
         is = xmlFile.getDownloadStream(0);        
         boolean importable = isImportable(is);    
@@ -308 +319 @@
         String pluginClassName = configuration.getAttributeValue("pluginClassName");
         
-      
         PluginDefinition pluginDefinition = PluginDefinition.getByClassName(dc, pluginClassName);
-        
-        PluginConfiguration pluginConfig = PluginConfiguration.getNew(dc, pluginDefinition);          
-        dc.saveItem(pluginConfig);
+        PluginConfiguration pluginConfig = PluginConfiguration.getNew(dc, pluginDefinition);
+        if (setPermissions)
+        {
+          pluginConfig.setItemKey(pluginDefinition.getItemKey());
+          pluginConfig.setProjectKey(pluginDefinition.getProjectKey());
+        }
         pluginConfig.setName(name);
         pluginConfig.setDescription(description);
+        dc.saveItem(pluginConfig);
         
         List parameters = configuration.getChildren("parameter");
@@ -345 +359 @@
             
       parameters.add(xmlFileParameter);
+      parameters.add(setPermissionsParameter);
       
       configureJob = new RequestInformation