Changeset 3792

Timestamp:

Sep 27, 2007, 9:58:47 AM (16 years ago)

Author:

Martin Svensson

Message:

Fixes #560 Deleting reporters

File:

• trunk/www/views/reporters/index.jsp (modified) (3 diffs)

trunk/www/views/reporters/index.jsp

@@ -41 +41 @@
   import="net.sf.basedb.core.DataQuery"
   import="net.sf.basedb.core.PermissionDeniedException"
+  import="net.sf.basedb.core.BaseException"
   import="net.sf.basedb.util.RemovableUtil"
   import="net.sf.basedb.util.ShareableUtil"
@@ -175 +176 @@
     ItemContext cc = Base.getAndSetCurrentContext(sc, itemType, pageContext, defaultContext);
     ReporterBatcher batcher = ReporterBatcher.getNew(dc);
-    batcher.delete(cc.getId());
-    batcher.close();
-    dc.commit();
-    redirect = listPage;
+    try
+    {
+      batcher.delete(cc.getId());
+      batcher.close();
+      dc.commit();    
+      redirect = listPage;
+    }
+    catch (BaseException bex)
+    {
+      message = "The reporter can not be deleted. " +
+        "Probably because it is used by other items";
+      redirect = viewPage + "&popmessage="+HTML.urlEncode(message);
+    }
   }
   else if ("DeleteItems".equals(cmd))
@@ -186 +196 @@
     ItemContext cc = Base.getAndSetCurrentContext(sc, itemType, pageContext, defaultContext);
     ReporterBatcher batcher = ReporterBatcher.getNew(dc);
+    batcher.setBatchSize(1);
+    int notDeleted = 0;
     for (int reporterId : cc.getSelected())
     {
-      batcher.delete(reporterId);
-    }
-    batcher.close();
+      try
+      {
+        batcher.delete(reporterId);
+      }
+      catch (BaseException bex)
+      {
+        notDeleted++;
+      }     
+    }   
     dc.commit();
-    redirect = listPage;
+    message = notDeleted > 0 ? notDeleted + " reporters can not be deleted. " +
+        "Probably because they are used by other items" : null;
+    redirect = listPage+(message != null ? "&popmessage="+HTML.urlEncode(message) : "");
   }
   else if ("ExportItems".equals(cmd))