Changeset 4098

Timestamp:

Jan 23, 2008, 3:13:38 PM (15 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #887: Internal job queue may start the same job more than once if running BASE on multiple Tomcat instances

As it turned out, the checks were already implemented by the job agent code and just needed to be copied into the internal job queue code.

File:

• trunk/src/core/net/sf/basedb/core/InternalJobQueue.java (modified) (1 diff)

trunk/src/core/net/sf/basedb/core/InternalJobQueue.java

@@ -433 +433 @@
         if (job.getStatus() != Job.Status.WAITING) return;
         
+        // Change the status to Job.Status.PREPARED
+        job.setPrepared(Application.getHostName());
+        try
+        {
+          dc.commit();
+        }
+        catch (ItemModifiedException ex)
+        {
+          // Another thread or process has started the job already, return 
+          // without starting the job
+          return;
+        }
+        finally
+        {
+          dc.close();
+        }
+        // Now we know that noby else is trying to execute the job
+        // Reload the job again in a new DbControl
+        dc = impersonated.newDbControl();
+        job = Job.getById(dc, jobId);
+        
         // Set the active project
         int projectId = job.getActiveProjectId();