Changeset 4123

Timestamp:

Feb 4, 2008, 1:32:08 PM (15 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #917: The progress reporter for a job should update the database if the progress is increased with >= 5%

File:

• trunk/src/core/net/sf/basedb/core/Job.java (modified) (2 diffs)

trunk/src/core/net/sf/basedb/core/Job.java

@@ -1271 +1271 @@
     */
     private static final long UPDATE_INTERVAL = 5 * 1000;
+
+    /**
+      Min percentage difference between updates to the database.
+    */
+    private static final int UPDATE_PERCENT = 5;
     
     private final SessionControl sc;
@@ -1301 +1306 @@
     public void display(int percent, String message)
     {
-      // Do not update unless at least some time has passed, or the plug-in has finished
-      if (System.currentTimeMillis() - lastUpdate > UPDATE_INTERVAL || percent == 100)
+      // Do not update unless at least :
+      // * some time has passed
+      // * the plug-in has finished (percent == 100)
+      // * progress has increased by at least 5%
+      if (System.currentTimeMillis() - lastUpdate >= UPDATE_INTERVAL || 
+          percent == 100 || percent - lastValue >= UPDATE_PERCENT)
       {
         // If the percent is negative and less then the last value, an offset will be calculated.