Changeset 4849

Timestamp:

Mar 26, 2009, 10:50:52 AM (15 years ago)

Author:

Nicklas Nordborg

Message:

References #1240: Implement "lazy loading" in the generic "item overview"

Disable validation when lazy-loading nodes, since we are not interested in the result.

Location:

branches/2.11-stable

Files:

• src/core/net/sf/basedb/util/overview/validator/BasicItemNodeValidatorFactory.java (modified) (4 diffs)
• src/core/net/sf/basedb/util/overview/validator/NodeValidatorFactory.java (modified) (1 diff)
• www/common/overview/index.jsp (modified) (1 diff)

branches/2.11-stable/src/core/net/sf/basedb/util/overview/validator/BasicItemNodeValidatorFactory.java

@@ -48 +48 @@
   private final Map<Object, Class<? extends NodeValidator<? extends BasicItem>>> validators;
   private boolean useNullValidator;
+  private boolean disabled;
   
   /**
@@ -56 +57 @@
     validators = new HashMap<Object, Class<? extends NodeValidator<? extends BasicItem>>>();
     this.useNullValidator = true;
+    this.disabled = false;
     registerDefaultNodeValidators();
   }
@@ -63 +65 @@
     ---------------------------------------
   */
+  
+  
+  @Override
+  public boolean isDisabled() 
+  {
+    return disabled;
+  }
+
+  @Override
+  public void setDisabled(boolean disabled) 
+  {
+    this.disabled = disabled;
+  }
+
   /**
     Create a new node validator that can validate nodes with items of 
@@ -78 +94 @@
   {
     NodeValidator<? extends BasicItem> validator = null;
-    Class<? extends NodeValidator<? extends BasicItem>> validatorClass = validators.get(key);
+    Class<? extends NodeValidator<? extends BasicItem>> validatorClass = 
+      disabled ? null : validators.get(key);
     if (validatorClass == null)
     {
-      if (useNullValidator)
+      if (useNullValidator || disabled)
       {
         validator = new NullNodeValidator<BasicItem>();

branches/2.11-stable/src/core/net/sf/basedb/util/overview/validator/NodeValidatorFactory.java

@@ -39 +39 @@
 
   /**
+    Disable/enabled node validation programmatically. When a 
+    node validator factory is disabled the {@link #createNodeValidator(Object)}
+    should return null or a {@link NullNodeValidator} for all
+    requests.
+    @param disabled TRUE to disable node validation
+    @since 2.11
+  */
+  public void setDisabled(boolean disabled);
+  
+  /**
+    Check if node validation has been disabled.
+    @return TRUE if validation has been disabled
+    @since 2.11
+  */
+  public boolean isDisabled();
+  
+  /**
     Create a node validator that knows how to validate nodes for items
     that are specified by the given key. The key can be almost anything.

branches/2.11-stable/www/common/overview/index.jsp

@@ -65 +65 @@
         null : Project.getById(dc, sc.getActiveProjectId());
     GenericOverview overview = OverviewUtil.getNewOrCurrentOverview(dc, item, project);
+    overview.getNodeValidatorFactory().setDisabled(true);
     overview.expand(dc, overview.getRootNode(), false);
-    overview.updateFailureCountOnNodes();
     dc.close();
     redirect = "frameset.jsp?ID="+ID+"&show_failures="+false;