Changeset 5037

Timestamp:

Jul 31, 2009, 9:20:53 AM (14 years ago)

Author:

Nicklas Nordborg

Message:

References #1350: Update to Hibernate 3.3.2

Added a very ugly hack that effectively disables the query plan cache in Hibernate. This forces all queries to be rebuilt from scratch at all times and ensures that the proper number of parameter placeholders are added to the final SQL. The disabling of the cache may result in some performance degradation but this has not yet been investigated.

File:

• trunk/src/core/net/sf/basedb/core/HibernateUtil.java (modified) (5 diffs)

trunk/src/core/net/sf/basedb/core/HibernateUtil.java

@@ -61 +61 @@
 import java.sql.DatabaseMetaData;
 import java.sql.SQLException;
+import java.lang.reflect.Field;
 import java.net.URL;
 import java.net.URI;
@@ -94 +95 @@
 import org.hibernate.tool.hbm2ddl.SchemaExport;
 import org.hibernate.tool.hbm2ddl.SchemaUpdate;
+import org.hibernate.util.SoftLimitMRUCache;
 import org.hibernate.metadata.ClassMetadata;
 import org.hibernate.dialect.Dialect;
@@ -99 +101 @@
 import org.hibernate.dialect.function.SQLFunctionTemplate;
 import org.hibernate.engine.Mapping;
+import org.hibernate.engine.query.QueryPlanCache;
+import org.hibernate.impl.SessionFactoryImpl;
 
 /**
@@ -199 +203 @@
       cfg.configure();
       sf = cfg.buildSessionFactory();
+      /*
+        =========================================================
+        VERY UGLY hack to solve a bug in Hibernate. See
+        http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
+        The hack replaces an internal query cache in Hibernate
+        with an implementation that simply ignores everything that
+        Hibernate tries to put in it. This code should be removed
+        as soon as Hibernate has released an update that fixes the
+        issue.
+        =========================================================
+      */
+      try
+      {
+        SessionFactoryImpl sfi = (SessionFactoryImpl)sf;
+        QueryPlanCache qpc = sfi.getQueryPlanCache();
+        Field pcf = QueryPlanCache.class.getDeclaredField("planCache");
+        pcf.setAccessible(true);
+        pcf.set(qpc, 
+            new SoftLimitMRUCache() 
+            {
+              private static final long serialVersionUID = -7082205080525320488L;
+              @Override
+              public Object put(Object key, Object value)
+              {
+                return null;
+              }
+            }
+        );
+      }
+      catch (Exception ex)
+      {
+        log.warn("Could not replace query plan cache in Hibernate", ex);
+      }
+      // =========================================================
+
     }
     catch (HibernateException ex)
@@ -1783 +1822 @@
       news = HibernateUtil.loadData(session, NewsData.class, newsId);
       ok = news == null;
+      /*
+      ===============================================
+      Code used to test the bug described in #init2()
+      ===============================================
+      System.out.println("Selecting news 1:");
+      session = HibernateUtil.newSession();
+      String hql = "SELECT n FROM NewsData n";
+      Filter f = session.enableFilter("memberOf");
+      List<Integer> idList = new ArrayList<Integer>();
+      idList.add(1);
+      f.setParameterList("items", idList);
+      f.setParameter("owner", 0);
+      Query q = session.createQuery(hql); 
+      System.out.println(q.list());
+      session.close();
+      
+      System.out.println("Selecting news 1+2:");
+      session = HibernateUtil.newSession();
+      f = session.enableFilter("memberOf");
+      idList.add(2);
+      f.setParameterList("items", idList);
+      f.setParameter("owner", 0);
+      System.out.println("creating query");
+      q = session.createQuery(hql);
+      System.out.println("query created");
+      System.out.println(q.list());
+      session.close();
+      */
+      
     }
     finally