Changeset 5057

Timestamp:

Aug 18, 2009, 2:46:43 PM (13 years ago)

Author:

Nicklas Nordborg

Message:

References #108: Logging the change history of an item

• Use WeakReference? in LogControl?.DbControl? to make sure the DbControl? is garbage collected correctly (test in TestDbControl? failed)

File:

• trunk/src/core/net/sf/basedb/core/LogControl.java (modified) (5 diffs)

trunk/src/core/net/sf/basedb/core/LogControl.java

@@ -22 +22 @@
 package net.sf.basedb.core;
 
+import java.lang.ref.WeakReference;
+
 import net.sf.basedb.core.data.ChangeHistoryData;
 import net.sf.basedb.core.data.ChangeHistoryDetailData;
@@ -37 +39 @@
 {
 
-  private final DbControl dc;
+  private final WeakReference<DbControl> dc;
   private TransactionDetails transactionDetails;
   private org.hibernate.StatelessSession session;
@@ -43 +45 @@
   LogControl(DbControl dc)
   {
-    this.dc = dc;
+    this.dc = new WeakReference<DbControl>(dc);
   }
   
@@ -54 +56 @@
     if (transactionDetails == null) 
     {
-      transactionDetails = new TransactionDetails(dc.getSessionControl());
+      transactionDetails = new TransactionDetails(dc.get().getSessionControl());
     }
     return transactionDetails;
@@ -110 +112 @@
   private org.hibernate.StatelessSession getSession()
   {
-    if (session == null) session = dc.getStatelessSession();
+    if (session == null) session = dc.get().getStatelessSession();
     return session;
   }