Changeset 5082

Timestamp:

Aug 28, 2009, 11:01:45 AM (13 years ago)

Author:

Nicklas Nordborg

Message:

References #1363: IE8 problems

It seems like it is no longer safe to pass objects between windows. If the window that created the object is closed, the object will no longer be usable in other places. This causes a problems for popup-windows that tried to "remember" the active tab. The information must be stored in the main page, and the array object is created by the popup page. But once the popup was closed, the array could no longer be used. The result was an error message: the object invoked has disconnected from its clients. The solution is to let the main page create the array.

Location:

branches/2.13-stable/www/include/scripts

Files:

• main.js (modified) (1 diff)
• tabcontrol.js (modified) (1 diff)

branches/2.13-stable/www/include/scripts/main.js

@@ -723 +723 @@
   
   /**
+    Save a key-value pair for a page.
+  */
+  this.setPageValue = function(page, key, value)
+  {
+    if (!window.top.pageValues) window.top.pageValues = new Array();
+    if (!window.top.pageValues[page]) window.top.pageValues[page] = new Array();
+    window.top.pageValues[page][key] = value;
+  }
+
+  /**
+    Get the saved value for the given key on a page
+  */
+  this.getPageValue = function(page, key)
+  {
+    if (!window.top.pageValues) return null;
+    if (!window.top.pageValues[page]) return null;
+    return window.top.pageValues[page][key];
+  }
+
+  /**
     Get all elements with a given <tag> and class="..."
   */

branches/2.13-stable/www/include/scripts/tabcontrol.js

@@ -124 +124 @@
   this.rememberActiveTab = function(window, tabControlId, tabId)
   {
-    if (!window.rememberedTabs) window.rememberedTabs = new Array();
-    var rememberedTabs = window.rememberedTabs;
-    var thisLocation = location.pathname;
-    if (!rememberedTabs[thisLocation]) rememberedTabs[thisLocation] = new Array();
-    rememberedTabs[thisLocation][tabControlId] = tabId;
+    if (window.Main) window.Main.setPageValue(location.pathname, tabControlId, tabId);
   }
   
   this.getRememberedTabId = function(window, tabControlId)
   {
-    if (!window.rememberedTabs) return null;
-    var rememberedTabs = window.rememberedTabs;
-    var thisLocation = location.pathname;
-    if (!rememberedTabs[thisLocation]) return null;
-    return rememberedTabs[thisLocation][tabControlId];
+    if (!window.Main) return null;
+    return window.Main.getPageValue(location.pathname, tabControlId);
   }