Changeset 6166

Timestamp:

Oct 11, 2012, 3:47:22 PM (10 years ago)

Author:

Nicklas Nordborg

Message:

References #1730: Move in-page onEvent attributes to external *.js files

• Fixed for the user settings dialog and the 'Reset list settings' dialog.
• Added a 'zoom' taglib which should make it easier to include the 'zoom' icon for textarea fields.
• Added new javascript function in main-2 for opening zoom dialog and calendar dialog

Location:

trunk

Files:

• src/clients/web/net/sf/basedb/clients/web/taglib/Icon.java (modified) (5 diffs)
• src/clients/web/net/sf/basedb/clients/web/taglib/Zoom.java (added)
• www/WEB-INF/base.tld (modified) (2 diffs)
• www/common/calendar.jsp (modified) (3 diffs)
• www/common/zoom.jsp (modified) (2 diffs)
• www/include/scripts/main-2.js (modified) (6 diffs)
• www/include/scripts/main.js (modified) (3 diffs)
• www/include/styles/main.css (modified) (1 diff)
• www/my_base/user/local.js (deleted)
• www/my_base/user/preferences.js (modified) (1 diff)
• www/my_base/user/reset_filters.js (added)
• www/my_base/user/reset_filters.jsp (modified) (3 diffs)
• www/my_base/user/settings.js (added)
• www/my_base/user/settings.jsp (modified) (18 diffs)
• www/my_base/user/submit_user.jsp (modified) (1 diff)

trunk/src/clients/web/net/sf/basedb/clients/web/taglib/Icon.java

@@ -115 +115 @@
     <td>no</td>
     <td>
+      Deprecated. Use javascript to attach an event handler instead.
       An optional JavaScript statement that will exceute when the user
       clicks on the icon.
@@ -167 +168 @@
     An optional JavaScript statement.
   */
+  @Deprecated
   private String onClick = null;
 
@@ -228 +230 @@
   }
 
+  @Deprecated
   public void setOnclick(String onClick)
   {
@@ -233 +236 @@
     if (!setEnabledIsCalled) this.enabled = onClick != null;
   }
+  @Deprecated
   public String getOnclick()
   {
@@ -269 +273 @@
     StringBuilder sb = new StringBuilder();
     sb.append("<span ");
-    addIdAndStyles(sb, getOnclick() != null ? "link" : null, isEnabled() ? null : "disabled");
+    addIdAndStyles(sb, getOnclick() != null || getId() != null ? "link" : null, isEnabled() ? null : "disabled");
     if (getTooltip() != null) sb.append(" title=\"").append(getTooltip()).append("\"");
-    if (getOnclick() != null && isEnabled()) 
-    {
-      sb.append(" onclick=\"").append(getOnclick()).append("\"");
-      if (getTabindex() >= 0) 
+    if (getOnclick() != null) 
+    {
+      // onclick event added as inline code
+      if (isEnabled())
+      {
+        sb.append(" onclick=\"").append(getOnclick()).append("\"");
+        if (getTabindex() >= 0) 
+        {
+          sb.append(" tabindex=\"").append(getTabindex()).append("\"");
+          sb.append(" onkeypress=\"Events.handleFocusedKeypress(event)\"");
+        }
+      }
+    }
+    else if (getId() != null)
+    {
+      // Assume onclick event is attached by javascript
+      if (isEnabled() && getTabindex() >= 0) 
       {
         sb.append(" tabindex=\"").append(getTabindex()).append("\"");
-        sb.append(" onkeypress=\"Main.handleFocusedKeypress(event)\"");
       }
     }
+    addDynamicAttributes(sb);
     sb.append(">");
     sb.append("<img src=\"").append(theImage).append("\" alt=\"*\">");

trunk/www/WEB-INF/base.tld

@@ -149 +149 @@
       <rtexprvalue>true</rtexprvalue>
     </attribute>
+    <dynamic-attributes>true</dynamic-attributes>
   </tag>
 
@@ -311 +312 @@
   
   <tag>
+    <name>zoom</name>
+    <tag-class>net.sf.basedb.clients.web.taglib.Zoom</tag-class>
+    <body-content>empty</body-content>
+    <attribute>
+      <name>id</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>clazz</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>subclass</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>style</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>image</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>textarea</name>
+      <required>true</required>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>title</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>tooltip</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>visible</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+    <attribute>
+      <name>tabindex</name>
+      <rtexprvalue>true</rtexprvalue>
+    </attribute>
+  </tag>
+  
+  <tag>
     <name>select</name>
     <tag-class>net.sf.basedb.clients.web.taglib.Select</tag-class>

trunk/www/common/calendar.jsp

@@ -44 +44 @@
   String title = request.getParameter("title");
   String form = request.getParameter("form");
-  String input = request.getParameter("input");
+  String textarea = request.getParameter("textarea");
   String callback = request.getParameter("callback");
   boolean datetime = Values.getBoolean(request.getParameter("datetime"));
@@ -70 +70 @@
   function getInitialDate()
   {
-    var frm = window.opener.document.forms['<%=form%>'];
-    var dateString = frm['<%=input%>'].value;
+    <%
+    if (form != null)
+    {
+      %>
+      var frm = window.opener.document.forms['<%=form%>'];
+      var textarea = frm['<%=textarea%>'];
+      <%
+    }
+    else
+    {
+      %>
+      var textarea = window.opener.document.getElementById('<%=textarea%>');
+      <%
+    }
+    %>
+    var dateString = textarea.value;
     var date = Dates.parseString(dateString, '<%=HTML.javaScriptEncode(format)%>');
     if (date == null) date = new Date();
@@ -94 +108 @@
     if (callback == null)
     {
-      %>
-      var frm = window.opener.document.forms['<%=form%>'];
-      frm['<%=input%>'].value = formattedDate;
-      <%
+      if (form != null)
+      {
+        %>
+        var frm = window.opener.document.forms['<%=form%>'];
+        frm['<%=textarea%>'].value = formattedDate;
+        <%
+      }
+      else
+      {
+        %>
+        window.opener.document.getElementById('<%=textarea%>').value = formattedDate;
+        <%
+      }
     }
     else
     {
       %>
-      window.opener.<%=callback%>('<%=form%>', '<%=input%>', formattedDate);
+      window.opener.<%=callback%>('<%=form%>', '<%=textarea%>', formattedDate);
       <%
     }

trunk/www/common/zoom.jsp

@@ -54 +54 @@
   {
     var frm = document.forms["zoom"];
-    frm.zoom.value = window.opener.document.forms['<%=form%>'].elements['<%=textarea%>'].value;
+    <%
+    if (form == null)
+    {
+      %>
+      var element = window.opener.document.getElementById('<%=textarea%>');
+      <%
+    }
+    else
+    {
+      %>
+      var element = window.opener.document.forms['<%=form%>'].elements['<%=textarea%>'];
+      <%
+    }
+    %>
+    frm.zoom.value = element.value;
     frm.zoom.focus();
+    frm.zoom.disabled = element.disabled;
   }
   function setTextAndClose()
   {
     var value = document.forms["zoom"].zoom.value;
-    var element = window.opener.document.forms['<%=form%>'].elements['<%=textarea%>'];
-    element.value = value;
-    element.focus();
+    <%
+    if (form == null)
+    {
+      %>
+      var element = window.opener.document.getElementById('<%=textarea%>');
+      <%
+    }
+    else
+    {
+      %>
+      var element = window.opener.document.forms['<%=form%>'].elements['<%=textarea%>'];
+      <%
+    }
+    %>
+    if (!element.disabled)
+    {
+      element.value = value;
+      element.focus();
+    }
     <%
     if (callback != null)
@@ -231 +262 @@
   </m:menu>
       <%
-      if (form.equals("help"))
+      if ("help".equals(form))
       {
       %>

trunk/www/include/scripts/main-2.js

@@ -82 +82 @@
   }
 
+  /**
+    Close the current popup window.
+  */
+  app.closeWindow = function()
+  {
+    window.top.close();
+  }
   
   /**
@@ -357 +364 @@
   }
   
+  /*
+    Event handler that can be attached to 'keypress' event for 
+    form input fields to block all keys except numeric (including minus, plus, decimal dot and E).
+  */
+  events.numberOnly = function(event)
+  {
+    var charCode = event.charCode || event.keyCode;
+    // <31 for tab, delete, etc. 48-57=key 0-9, 45= '-', 46='.', 69/101=E/e
+    var allow = charCode <= 31 || (charCode >= 48 && charCode <= 57) || charCode == 45 || charCode == 46 || charCode == 69 || charCode == 101;
+    if (!allow) event.preventDefault();
+  }
+
+  
   /**
     Event handler that can be attached to any event/element that
@@ -507 +527 @@
 }();
 
-var Help = function()
+/**
+  Functions that open common popup dialog windows.
+*/
+var Dialogs = function()
 {
-  var help = {};
+  var dialogs = {};
   var internal = {};
 
@@ -516 +539 @@
     @param helpId The ID of the help information
   */
-  help.openHelp = function(helpId)
+  dialogs.openHelp = function(helpId)
   {
     var url = App.getRoot()+'common/help/view_help.jsp?ID='+App.getSessionId()+'&external_id='+helpId;
@@ -528 +551 @@
     @param helpId Optional, a default help id if no help is specified by the tab control
   */
-  help.openTabControlHelp = function(tabControl, helpId)  
+  dialogs.openTabControlHelp = function(tabControl, helpId) 
   {
     var useHelpId = TabControl.getActiveHelpId(tabControl);
     if (!useHelpId) useHelpId = helpId;
-    help.openHelp(useHelpId);
+    dialogs.openHelp(useHelpId);
+  }
+  
+  /*
+    Open a popup window with a large textarea field for editing text.
+    @param textarea A form input/textarea element or the id of an element
+    @param title The title that the popup dialog should have
+  */
+  dialogs.openZoom = function(textarea, title)
+  {
+    textarea = Doc.element(textarea);
+    if (!title) title = textarea.id;
+    var url = App.getRoot()+'common/zoom.jsp?ID='+App.getSessionId();
+    url += '&title='+encodeURIComponent(title)+'&textarea='+textarea.id;
+    Main.openPopup(url, title.replace(/[^\w]/g, ''), 640, 600);
+  }
+  
+  /*
+    Open a popup window for selecting a date or datetime value.
+    @param textarea A form input/textarea element or the id of an element
+    @param title The title that the popup dialog should have
+    @param dateFormat The dateformat to use when reading/writing the value
+    @param useTime 'true' to use date+time, 'false' to only use date
+  */
+  dialogs.openCalendar = function(textarea, title, dateFormat, useTime)
+  {
+    textarea = Doc.element(textarea);
+    if (!title) title = textarea.id;
+    var url = App.getRoot()+'common/calendar.jsp?ID='+App.getSessionId();
+    url += '&title='+encodeURIComponent(title)+'&textarea='+textarea.id+'&format='+encodeURIComponent(dateFormat);
+    if (useTime) url += '&datetime=1';
+    Main.openPopup(url, title.replace(/[^\w]/, ''), 450, 300);
   }
   
   /**
     Help icon 'click' handler. The help id is found on the target element's
-    'help-id' attribute or with the help of the active tab control on the
-    'tabcontrol-id' attribute.
+    'data-help-id' attribute or with the help of the active tab control on the
+    'data-tabcontrol-id' attribute.
   */
   internal.helpOnClick = function(event)
@@ -548 +602 @@
     if (tabControlId)
     {
-      help.openTabControlHelp(tabControlId, helpId);
+      dialogs.openTabControlHelp(tabControlId, helpId);
     }
     else if (helpId)
     {
-      help.openHelp(helpId);
-    }
-  }
-  
-  /**
-    Initializer that add 'onclick' event handlers to all 'help' elements.
-  */
-  internal.addOnClickHandler = function(hlp, autoInit)
-  {
-    if (autoInit != 'help') return;
-    Events.addEventHandler(hlp, 'click', internal.helpOnClick);
-    if (hlp.tabIndex >= 0)
-    {
-      Events.enableClickOnEnter(hlp);
+      dialogs.openHelp(helpId);
+    }
+  }
+  
+  /**
+    Zoom icon 'click' handler. The id of the textarea is found on the target
+    element's 'data-textarea-id' attribute. The dialog title can be specified
+    using the 'data-title' attribute, otherwise the textarea-id is used.
+   */
+  internal.zoomOnClick = function(event)
+  {
+    var zoom = event.currentTarget;
+    var textAreaId = Data.get(zoom, 'textarea-id');
+    var dialogTitle = Data.get(zoom, 'title', textAreaId);
+    dialogs.openZoom(textAreaId, dialogTitle);
+  }
+  
+  /**
+    Initializer that add 'onclick' event handlers to common
+    elements: 'help', 'zoom', etc.
+  */
+  internal.addOnClickHandler = function(element, autoInit)
+  {
+    if (autoInit == 'help')
+    {
+      Events.addEventHandler(element, 'click', internal.helpOnClick);
+    }
+    else if (autoInit == 'zoom')
+    {
+      Events.addEventHandler(element, 'click', internal.zoomOnClick);
+    }
+    else
+    {
+      return;
+    }
+    if (element.tabIndex >= 0)
+    {
+      Events.enableClickOnEnter(element);
     }
   }
   Doc.addElementInitializer(internal.addOnClickHandler);
   
-  return help;
+  return dialogs;
 }();
 

trunk/www/include/scripts/main.js

@@ -279 +279 @@
   this.openHelp = function(ID, helpid)  
   {
-    Help.openHelp(helpid);
+    Dialogs.openHelp(helpid);
   }
 
@@ -293 +293 @@
   this.openTabControlHelp = function(ID, tabcontrol, helpId)  
   {
-    Help.openTabControlHelp(tabcontrol, helpId);
+    Dialogs.openTabControlHelp(tabcontrol, helpId);
   }
 
@@ -1501 +1501 @@
   this.selectDateTime = function(title, form, input, callback, format)
   {
-    var url = getRoot()+'common/calendar.jsp?datetime=1&title='+escape(title)+'&form='+form+'&input='+input+'&format='+escape(format);
+    var url = getRoot()+'common/calendar.jsp?datetime=1&title='+escape(title)+'&form='+form+'&textarea='+input+'&format='+escape(format);
     url += '&ID='+getSessionId();
     if (callback) url += '&callback='+callback;

trunk/www/include/styles/main.css

@@ -288 +288 @@
 }
 
-img.helpicon
+img.helpicon, img.zoomicon
 {
   cursor: pointer;

trunk/www/my_base/user/preferences.js

@@ -31 +31 @@
     // Save + Close buttons
     Buttons.addClickHandler('btnSave', Preferences.save);
-    Buttons.addClickHandler('close', Main.closeWindow);
+    Buttons.addClickHandler('close', App.closeWindow);
     
     // Validation

trunk/www/my_base/user/reset_filters.jsp

@@ -73 +73 @@
   %>
   <base:page type="popup" title="<%=title%>">
-  <base:head scripts="~local.js" />
+  <base:head scripts="~reset_filters.js" />
   <base:body>
     <h1><%=title%><base:help helpid="userpreferences.resetfilters" /></h1>
@@ -85 +85 @@
         <th>Which list?</th>
         <td>
-          <select name="item_type" onchange="Filters.itemTypeOnChange()" class="selectionlist">
+          <select name="item_type" id="itemType" class="selectionlist">
             <option value="">- all -
             <%
@@ -122 +122 @@
 
     <base:buttongroup subclass="dialogbuttons">
-      <base:button onclick="Filters.reset();" title="Ok" />
-      <base:button onclick="window.close();" title="Cancel" />
+      <base:button id="btnOk" title="Ok" />
+      <base:button id="close" title="Cancel" />
     </base:buttongroup>
   </base:body>

trunk/www/my_base/user/settings.jsp

@@ -95 +95 @@
 %>
   <base:page type="popup" title="<%=title%>">
-  <base:head scripts="~local.js,tabcontrol.js" styles="tabcontrol.css" />
+  <base:head scripts="tabcontrol-2.js,~settings.js" styles="tabcontrol.css" />
   <base:body>
     <h1><%=title%><base:help tabcontrol="settings" /></h1>
@@ -113 +113 @@
       position="bottom" remember="false">
   
-      <t:tab id="contact" title="Contact information" validate="Settings.validateContact()" helpid="userpreferences.contact">
+      <t:tab id="contact" title="Contact information" helpid="userpreferences.contact">
         <table class="fullform input100">
         <tr>
@@ -151 +151 @@
           <th>Address</th>
           <td>
-            <textarea <%=ifDisabled%> rows="4" name="address"><%=HTML.encodeTags(user.getAddress())%></textarea>
+            <textarea <%=ifDisabled%> rows="4" name="address" id="address"><%=HTML.encodeTags(user.getAddress())%></textarea>
           </td>
           <td style="width: 20px;">
-            <base:icon image="zoom.png" 
-              onclick="Main.zoom('Address', 'user', 'address')" 
-              visible="<%=writePermission%>"
-              tooltip="Edit in larger window" />
+            <base:zoom textarea="address" title="Address" />
           </td>
         </tr>
@@ -183 +180 @@
       </t:tab>
       
-      <t:tab id="password" title="Password" validate="Settings.validatePassword()" helpid="userpreferences.password">
+      <t:tab id="password" title="Password" helpid="userpreferences.password">
         <table class="fullform input100">
         <% if (!Application.isUsingInternalAuthentication() && writePermission)
@@ -216 +213 @@
     
       <t:tab id="other" title="Other information" 
-        validate="Settings.validateExtendedProperties()" helpid="userpreferences.other">
+        helpid="userpreferences.other">
         <table class="fullform input100">
         <%
@@ -224 +221 @@
           {
             String name = ep.getName();
+            String fieldName = "ep."+name;
             Type type = ep.getType();
             boolean required = !ep.isNullable();
@@ -237 +235 @@
               {
                 %>
-                <input <%=isRequired%> <%=ifDisabled %> type="text" name="<%=name%>" 
-                  value="<%=value == null ? "" : value%>" style="width: 15em;"
-                  maxlength="20" onkeypress="return Numbers.integerOnly(event)"
-                  >
+                <input <%=isRequired%> <%=ifDisabled %> type="text" name="<%=fieldName%>" id="<%=fieldName%>"
+                  value="<%=value == null ? "" : value%>" style="width: 15em;" maxlength="20">
                 <%
               }
@@ -246 +242 @@
               {
                 %>
-                <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=name%>"
-                  value="<%=value == null ? "" : value%>" style="width: 15em;"
-                  maxlength="20" onkeypress="return Numbers.numberOnly(event)"
-                  >
+                <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=fieldName%>" id="<%=fieldName%>"
+                  value="<%=value == null ? "" : value%>" style="width: 15em;" maxlength="20">
                 <%
               }
@@ -255 +249 @@
               {
                 %>
-                <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=name%>"
+                <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=fieldName%>"
                   value="<%=HTML.encodeTags((String)value)%>"
-                  maxlength="<%=ep.getLength()%>"
-                  >
+                  maxlength="<%=ep.getLength()%>">
                 <%
               }
@@ -265 +258 @@
                 addZoom = true;
                 %>
-                <textarea <%=isRequired%> <%=ifDisabled%> name="<%=name%>" rows="6"  
+                <textarea <%=isRequired%> <%=ifDisabled%> name="<%=fieldName%>" id="<%=fieldName%>" rows="6"  
                   ><%=HTML.encodeTags((String)value)%></textarea>
                 <%
@@ -275 +268 @@
                 {
                   %>
-                  <input type="radio" name="<%=name%>" id="<%=name%>.null" value=""
+                  <input type="radio" name="<%=fieldName%>" id="<%=fieldName%>.null" value=""
                     <%=b == null ? "checked" : ""%> 
-                    ><label for="<%=name%>.null"><i>- not specified -</i></label><br>
+                    ><label for="<%=fieldName%>.null"><i>- not specified -</i></label><br>
                   <%
                 }
                 %>
-                <input type="radio" name="<%=name%>" id="<%=name%>.true" value="true" 
+                <input type="radio" name="<%=fieldName%>" id="<%=fieldName%>.true" value="true" 
                   <%=b != null && b == true ? "checked" : ""%>
-                  ><label for="<%=name%>.true">true</label><br>
-                <input type="radio" name="<%=name%>" id="<%=name%>.false" value="false" 
+                  ><label for="<%=fieldName%>.true">true</label><br>
+                <input type="radio" name="<%=fieldName%>" id="<%=fieldName%>.false" value="false" 
                   <%=b != null && b == false ? "checked" : ""%>
-                  ><label for="<%=name%>.false">false</label>
+                  ><label for="<%=fieldName%>.false">false</label>
                 <%
               }
@@ -295 +288 @@
                 <tr>
                 <td>
-                  <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=name%>" 
+                  <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=fieldName%>" id="<%=fieldName%>"
                     value="<%=dateFormatter.format((Date)value)%>" style="width: 15em;"
                     maxlength="20" title="Enter date in format: <%=dateFormat%>"
@@ -302 +295 @@
                 <td>
                   <base:button 
-                    onclick="<%="Dates.selectDate('"+HTML.javaScriptEncode(ep.getTitle())+"', 'user', '"+name+"', null, '"+jsDateFormat +"')"%>" 
+                    id="<%="btn."+fieldName%>"
+                    data-extended-property="<%=name%>"
                     image="calendar.png"
                     title="Calendar&hellip;" 
@@ -319 +313 @@
                 <tr>
                 <td>
-                  <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=name%>" 
+                  <input <%=isRequired%> <%=ifDisabled%> type="text" name="<%=fieldName%>" id="<%=fieldName%>"
                     value="<%=dateTimeFormatter.format((Date)value)%>" style="width: 15em;"
                     maxlength="20" title="Enter timestamp in format: <%=dateTimeFormat%>"
@@ -326 +320 @@
                 <td>
                   <base:button 
-                    onclick="<%="Dates.selectDateTime('"+HTML.javaScriptEncode(ep.getTitle())+"', 'user', '"+name+"', null, '"+jsDateTimeFormat +"')"%>" 
+                    id="<%="btn."+fieldName%>"
+                    data-extended-property="<%=name%>"
                     image="calendar.png"
                     title="Calendar&hellip;" 
@@ -340 +335 @@
               </td>
               <td style="width: 20px;">
-                <%if (addZoom)
+                <%
+                if (addZoom)
                 {
                   %>
-                  <base:icon image="zoom.png" 
-                  onclick="<%="Main.zoom('" + HTML.javaScriptEncode(ep.getTitle()) + "', 'user', '" + name + "')"%>"
-                    tooltip="Edit in larger window"
-                    visible="<%=writePermission%>"
-                  />
+                  <base:zoom textarea="<%=fieldName%>" title="<%=HTML.encodeTags(ep.getTitle()) %>" />
                   <%
                 }
@@ -360 +352 @@
           <th>Description</th>
           <td>
-            <textarea <%=ifDisabled%> rows="5" name="description"><%=HTML.encodeTags(user.getDescription())%></textarea>
+            <textarea <%=ifDisabled%> rows="5" name="description" id="description"><%=HTML.encodeTags(user.getDescription())%></textarea>
           </td>
           <td style="width: 20px;">
-            <base:icon image="zoom.png" 
-              onclick="Main.zoom('Description', 'user', 'description')"
-              tooltip="Edit in larger window"
-              visible="<%=writePermission%>"
-            />
+            <base:zoom textarea="description" title="Description" />
           </td>
         </tr>
@@ -376 +364 @@
   
     <base:buttongroup subclass="dialogbuttons">
-      <base:button onclick="Settings.save();" title="Save" visible="<%=writePermission%>"/>
-      <base:button onclick="window.close();" title="Cancel" visible="<%=writePermission%>"/>
-      <base:button onclick="window.close();" title="Close" visible="<%=!writePermission%>"/>
+      <base:button id="btnSave" title="Save" visible="<%=writePermission%>"/>
+      <base:button id="close" title="Cancel" visible="<%=writePermission%>"/>
+      <base:button id="close" title="Close" visible="<%=!writePermission%>"/>
     </base:buttongroup>
   

trunk/www/my_base/user/submit_user.jsp

@@ -101 +101 @@
         String name = ep.getName();
         Formatter formatter = FormatterFactory.getExtendedPropertyFormatter(sc, ep);
-        Object value = formatter.parseString(Values.getStringOrNull(request.getParameter(name)));
+        Object value = formatter.parseString(Values.getStringOrNull(request.getParameter("ep."+name)));
         user.setExtended(name, value);
       }