Changeset 6591

Timestamp:

Nov 11, 2014, 7:54:32 AM (8 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #1846: Prevent browser from asking about saving password when login extension doesn't want to

Fixed by making a clone of the main form with only hidden elements which is then submitted instead of the original form. This avoids triggering the dialog in the browser since it has no password-type field.

Location:

trunk/www

Files:

• include/scripts/main-2.js (modified) (1 diff)
• login.js (modified) (1 diff)

trunk/www/include/scripts/main-2.js

@@ -2284 +2284 @@
   
   /**
+    Clone the given form and add all elements in it as
+    hidden elements in the cloned form. Note that unselected
+    checkboxes and radio buttons are not cloned. Selection lists
+    with multiple selections are cloned as multiple hidden fields.
+  */
+  forms.cloneAsHidden = function(frm)
+  {
+    // Duplicate in hidden form
+    var cloned = document.createElement('form');
+    cloned.setAttribute('action', frm.action);
+    cloned.setAttribute('method', frm.method);
+    if (frm.target)
+    {
+      cloned.setAttribute('target', frm.target);
+    }
+    
+    for (var i = 0; i < frm.elements.length; i++)
+    {
+      var e = frm.elements[i];
+      var shouldClone = e.type == 'text' ||  e.type == 'textarea' || e.type == 'select-one' || e.type == 'password' || e.type == 'hidden';
+      shouldClone |= (e.type == 'radio' || e.type == 'checkbox' ) && e.checked; 
+      if (shouldClone)
+      {
+        Forms.addHidden(cloned, e.name, e.value);
+      }
+      else if (e.type == 'select-multiple')
+      {
+        for (var j = 0; j < e.length; j++)
+        {
+          if (e[j].selected) Forms.addHidden(cloned, e.name, e[j].value);
+        }
+      }
+    }
+    return cloned;
+  }
+  
+  /**
     Event handler that check/uncheck all checkboxes in a form. The form
     should be specified in the target element's data-form attribute. The 

trunk/www/login.js

@@ -191 +191 @@
     
     if (frm.target) Dialogs.openPopup('', frm.target, 300, 200);
-    frm.submit();
+    if (!pUseLastLogin)
+    {
+      // Duplicate in hidden form
+      var frm2 = Forms.cloneAsHidden(frm);
+      document.body.appendChild(frm2);
+      frm2.submit();
+      document.body.removeChild(frm2);
+    }
+    else
+    {
+      frm.submit();
+    }
+    
   }