Changeset 6714

Timestamp:

Feb 3, 2015, 1:02:57 PM (9 years ago)

Author:

Nicklas Nordborg

Message:

References #1914: Exception from DbCleaner?

Divide the delete query into chunks of 10000 at a time. This is well below the limit in PostgreSQL and hopefully works in MySQL as well, though I have not been able to find any information about any limit for MySQL.

File:

• branches/3.4-stable/src/core/net/sf/basedb/core/ChangeHistory.java (modified) (3 diffs)

branches/3.4-stable/src/core/net/sf/basedb/core/ChangeHistory.java

@@ -22 +22 @@
 package net.sf.basedb.core;
 
+import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
@@ -158 +159 @@
   }
   
+  private static final int MAX_PARAMETERS_IN_QUERY = 10000;
   
   /**
@@ -218 +220 @@
         */
         query.setInteger("type", itemType);
-        List<Integer> stray = HibernateUtil.loadList(Integer.class, query, null);
-        if (stray.size() > 0)
+        List<Integer> stray = new ArrayList<Integer>(HibernateUtil.loadList(Integer.class, query, null));
+        int startIndex = 0;
+        int endIndex = Math.min(MAX_PARAMETERS_IN_QUERY, stray.size());
+        while (startIndex < stray.size())
         {
-          deleteQuery.setParameterList("ids", stray, TypeWrapper.INTEGER.getHibernateType());
+          deleteQuery.setParameterList("ids", stray.subList(startIndex, endIndex), TypeWrapper.INTEGER.getHibernateType());
           numDeleted += HibernateUtil.executeUpdate(deleteQuery);
+          startIndex = endIndex;
+          endIndex = Math.min(startIndex + MAX_PARAMETERS_IN_QUERY, stray.size());
         }
         index++;