Changeset 7465

Timestamp:

Mar 28, 2018, 9:26:14 AM (6 years ago)

Author:

Nicklas Nordborg

Message:

References #2110: QueryException? in annotation importer plug-in

Implemented a method for removing old "synthetic" parameters that Hibernate generates under the hood (​https://github.com/hibernate/hibernate-orm/blob/5.2/hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java#L525).

The method uses the Java reflektion API to get access to a private variable inside an internal Hibernate class (QueryParameterBindingsImpl.parameterBindingMap). This solution may stop working if Hibernate is updated. The TestAnnotationFlatFileImporter is expected to fail in that case.

File:

• branches/3.12-stable/src/core/net/sf/basedb/core/hibernate/NativeQueryWrapper.java (modified) (4 diffs)

branches/3.12-stable/src/core/net/sf/basedb/core/hibernate/NativeQueryWrapper.java

@@ -22 +22 @@
 package net.sf.basedb.core.hibernate;
 
+import java.lang.reflect.Field;
 import java.util.Calendar;
 import java.util.Collection;
 import java.util.Date;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -39 +41 @@
 import org.hibernate.query.NativeQuery;
 import org.hibernate.query.QueryParameter;
+import org.hibernate.query.internal.AbstractProducedQuery;
+import org.hibernate.query.internal.QueryParameterBindingsImpl;
+import org.hibernate.query.spi.QueryParameterBinding;
 import org.hibernate.engine.query.spi.sql.NativeSQLQueryReturn;
 import org.hibernate.type.Type;
@@ -62 +67 @@
   }
 
+  /**
+    Get the underlying parent query from Hibernate.
+  */
+  public NativeQuery<R> getParentQuery()
+  {
+    return query;
+  }
+  
   @Override
   @Deprecated
@@ -498 +511 @@
   }
   
+  
+  // Reference to the "QueryParameterBindingsImpl.parameterBindingMap" variable
+  private Field parameterBindingMap;
+  
+  /**
+    We need to remove "synthetic" parameters from the "parameterBindingMap".
+    The parameters are created by Hibernate when a list-type parameter is 
+    specified on a query: name_0, name_1, etc. The problem is that the 
+    "synthetic" parameters are never cleared and if the same query is re-used
+    with a shorter list, Hibernate will try to set the non-existing parameters
+    which causes an exception. See http://base.thep.lu.se/ticket/2110
+  */
+  @SuppressWarnings({ "unchecked", "rawtypes" })
   private void clearOldParameterListParameters(String parameterName)
-  {}
+  {
+    try
+    {
+      if (parameterBindingMap == null)
+      {
+        parameterBindingMap = QueryParameterBindingsImpl.class.getDeclaredField("parameterBindingMap");
+        parameterBindingMap.setAccessible(true);
+      }
+      
+      String prefixOfParametersToRemove = parameterName + "_";
+      Map<QueryParameter<?>, QueryParameterBinding<?>> m = (Map)parameterBindingMap.get(((AbstractProducedQuery)query).getQueryParameterBindings());
+      Iterator<QueryParameter<?>> i = m.keySet().iterator();
+      while (i.hasNext())
+      {
+        String name = i.next().getName();
+        if (name.startsWith(prefixOfParametersToRemove)) 
+        {
+          i.remove();
+        }
+      }
+    }
+    catch (Exception ex)
+    {
+      throw new RuntimeException(ex);
+    }
+  }
 }