Changeset 7705

Timestamp:

May 13, 2019, 8:36:31 AM (4 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #2175: NullPointerException? when impersonating a user

We need to make sure that the information about role membership is up to date when trying to inactivate a role.

The reason that it worked for regular logins was that a check for permissions to use the web client is made before roles are inactivated. The check triggered a re-load and the 'roles' variable was not null.

File:

• branches/3.15-stable/src/core/net/sf/basedb/core/Keyring.java (modified) (1 diff)

branches/3.15-stable/src/core/net/sf/basedb/core/Keyring.java

@@ -799 +799 @@
   synchronized boolean setRoleInactive(int roleId, boolean inactive)
   {
+    if (getReload()) reload();
     // Ignore roles that the user is not a member of
-    if (!roles.contains(roleId)) return false;
+    if (roles == null || !roles.contains(roleId)) return false;
     
     if (inactiveRoles == null) inactiveRoles = new HashSet<Integer>();