Changeset 7834 for trunk/www/views/itemlists/members/index.jsp

Timestamp:

Jun 26, 2020, 12:51:46 PM (2 years ago)

Author:

Nicklas Nordborg

Message:

Fixes #2216: Improve API for adding and removing items to an item list

Added a test case for the new add and remove methods.

Existing functionality in the web client has been updated to use the new API.

File:

• trunk/www/views/itemlists/members/index.jsp (modified) (2 diffs)

trunk/www/views/itemlists/members/index.jsp

@@ -223 +223 @@
       query.setMaxResults(-1);
     }
-    int count = list.add(query.iterate(dc));
+    int count = list.add(query);
     dc.commit();
     message = count + " members added to list";
@@ -231 +231 @@
     // Delete all selected items on the list page
     ItemContext cc = Base.getAndSetCurrentContext(sc, itemType, subContext, pageContext, defaultContext);
-    for (int itemId : cc.getSelected())
-    {
-      list.removeItem((Listable)itemType.getById(dc, itemId));
-    }
+    list.removeItems(cc.getSelected());
     dc.commit();
     redirect = listPage;