Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1841 closed defect (fixed)

Investigate problems with popup windows

Reported by: Nicklas Nordborg Owned by: everyone
Priority: minor Milestone: BASE 3.3.1
Component: web Version:
Keywords: Cc:

Description

There have been examples when popup windows have opened ridiculously large the first time. If the size is corrected and the popup closed, the next time it is opened it is very small (typically the smallest allowed size).

This is not easy to reproduce because suddenly it seems to work again.

It has happened in Firefox on both Mac and Windows.

Change History (3)

comment:1 Changed 7 years ago by Nicklas Nordborg

(In [6529]) References #1841: Investigate problems with popup windows

I was not able to repoduce the problems. Main suspect is a timeout in popup.js that was too short and caused the browser to report bogus window sizes. The timeout is not really critical as long as the user doesn't resize the browser window before the timeout.

It could also be an issue with 'close_popup' script that re-applied the size correction a second time, though this should only be noticable at the pixel level and the issue was seen also when aborting a dialog without saving. In any case, the 'close_popup' script has been fixed so that it doesn't care about dialog positions anymore.

The dialog positions are now stored in the 'localStorage' instead of in javascript variables. This should makes it possible to remember positions between browser restarts, but to be on the safe side against filling the local storage or currupted values, the old values are forgotten when logging in.

comment:2 Changed 7 years ago by Nicklas Nordborg

Resolution: fixed
Status: newclosed

Let's see if this helps or not.

comment:3 Changed 7 years ago by Nicklas Nordborg

It did not help, but another possible cause has been found. See #1851.

Note: See TracTickets for help on using tickets.