Opened 15 years ago

Closed 14 years ago

#375 closed enhancement (fixed)

Shared items: the shareness of items should be listed in the properties view of the item

Reported by: Jari Häkkinen Owned by: Martin Svensson
Priority: minor Milestone: BASE 2.4
Component: web Version:
Keywords: Cc:

Description

As it is now the properties view will tell the user that the item is shared, but one needs to click on the share button to find out that it is shared.

Maybe the yellow hoover text in item listings should reveal the sharees also?

Change History (14)

comment:1 Changed 15 years ago by Jari Häkkinen

Milestone: BASE 2.x+
Summary: Shared items: the sharees of items should be listed in the properties view of the itemShared items: the shareness of items should be listed in the properties view of the item

comment:2 Changed 15 years ago by Jari Häkkinen

Milestone: BASE 2.x+BASE 2.4

comment:3 Changed 15 years ago by Johan Enell

Owner: changed from Johan Enell to Nicklas Nordborg

comment:4 Changed 15 years ago by Jari Häkkinen

Milestone: BASE 2.4BASE 2.3

Milestone BASE 2.4 deleted

comment:5 Changed 15 years ago by Nicklas Nordborg

Priority: majorminor

comment:6 Changed 14 years ago by Martin Svensson

Owner: changed from Nicklas Nordborg to Martin Svensson
Status: newassigned

comment:7 Changed 14 years ago by Martin Svensson

(In [3547]) References #375. The first part is done, listing which users/groups/projects an item is shared to

comment:8 Changed 14 years ago by Martin Svensson

It will probably be to much information in the tooltip if every project, group and user an item is shared to should be listed
Instead the number of each could be displayed, eg. 'This item is shared to: 2 projects, 1 group and 4 users.(?)

comment:9 Changed 14 years ago by Martin Svensson

(In [3548]) References #375.Missed one view-page in the last commit

comment:10 Changed 14 years ago by Martin Svensson

(In [3551]) References #375. Added column with projects, groups, users that an item is shared to. First list page is done, the rest of the list pages will also soon be checked in.

comment:11 Changed 14 years ago by Nicklas Nordborg

I think the code needs to be improved:

  • The names of the users, groups and projects should be linked in the same way as for all other items.
  • The code doesn't escape HTML in the names
  • Use the isShared() method to check if an item is shared before starting to load users, groups and projects. It will probably save a few queries.

I think the entire code that is generating the list of users, groups and projects could be put in some utility class (PermissionUtil??) and then called from all JSP pages with a one-liner:

<tbl:cell column="sharedTo"><%=PermissionUtil.getSomething(item)%></tbl:cell>

comment:12 Changed 14 years ago by Martin Svensson

(In [3552]) References #375. Only wants to do a commit before the weekend.

comment:13 Changed 14 years ago by Martin Svensson

(In [3553]) References #375. The list pages is done but the view pages should be updated to implement the ShareableUtil?.getSharedTo(..) instead of current solution, before this ticket can be closed

comment:14 Changed 14 years ago by Martin Svensson

Resolution: fixed
Status: assignedclosed

Decided after a closer look to not change the view-pages.

Note: See TracTickets for help on using tickets.