Opened 14 years ago

Closed 14 years ago

#737 closed defect (invalid)

Script that fixes copyright text may also add extra new line to end of files

Reported by: Nicklas Nordborg Owned by: Jari Häkkinen
Priority: major Milestone: BASE 2.4.4
Component: web Version:
Keywords: Cc:

Description

I am not sure if the extra new line at the end of www/filemanager/upload/show_exception.jsp was caused by the script or by something else. The newline appeared at revision 3675 with log message: Fixing copyright statements. Fixing svn properties.

Change History (4)

comment:1 Changed 14 years ago by Jari Häkkinen

Owner: changed from everyone to Jari Häkkinen
Status: newassigned

I'll add an ticket to the svndigest project and request that they check if the extra line is their problem.

Is this a problem for JSP's in general? Of course, no extra information should be added but some text editors are very eager to add an extra line in the end of an file automatically.

comment:2 Changed 14 years ago by Nicklas Nordborg

The extra new line is converted into a call to out.print("\n") when the JSP is compiled to a java servlet. In most cases this means nothing, but on the www/filemanager/upload/show_exception.jsp the last "real" statement is a throw exception statement. Thus, the java compiler complains about an unreachable statement (see ticket #736) and refuses to compile the JSP.

Actually, JSP:s are not so good for things that don't produce HTML and I think it would be better if the file upload was implemented as a pure servlet instead (ticket #738).

comment:3 Changed 14 years ago by Jari Häkkinen

Milestone: BASE 2.4.2

comment:4 Changed 14 years ago by Jari Häkkinen

Resolution: invalid
Status: assignedclosed

This was an issue here for the affected files, but the problem belongs to the svndigest project and they have resolved it in http://trac.thep.lu.se/trac/svndigest/ticket/264

Note: See TracTickets for help on using tickets.