Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#738 closed enhancement (fixed)

Implement file upload as a pure servlet

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: minor Milestone: BASE 2.16
Component: web Version:
Keywords: Cc:

Description

The JSP:s used for file upload are sensitive to line breaks in the JSP code. See ticket #736 and #737. It would be more stable to use a pure servlet for the file upload.

Change History (8)

comment:1 Changed 14 years ago by Jari Häkkinen

Milestone: BASE 2.5

comment:2 Changed 14 years ago by Jari Häkkinen

Milestone: BASE 2.5BASE 2.6

comment:3 Changed 14 years ago by Martin Svensson

Owner: changed from everyone to Martin Svensson
Status: newassigned

comment:4 Changed 14 years ago by Johan Enell

Milestone: BASE 2.6BASE 2.x+
Owner: Martin Svensson deleted
Status: assignednew

comment:5 Changed 11 years ago by Nicklas Nordborg

Milestone: BASE 2.x+BASE 2.16
Owner: set to Nicklas Nordborg
Priority: majorminor
Status: newassigned

comment:6 Changed 11 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [5395]) Fixes #738: Implement file upload as a pure servlet

It is not the file upload itself that is the real problem, it is the fact that the upload is sent to a hidden frame and that it is difficult to handle errors (eg. show them to the user). The new solution is to simply let the error be generated in the hidden frame and then use a javascript callback in the parent window to re-size the frames so that the upload-frame becomes visible instead.

I have also got rid of the non-ajax version of progress reporter since this could also cause problems. The progress reporting is no longer responsible for any error handling (since it is possible for an error to happen before the progress reporting infrastructure has been setup).

comment:7 Changed 11 years ago by Nicklas Nordborg

(In [5397]) References #738: Implement file upload as a pure servlet

This should have been part of [5395].

comment:8 Changed 11 years ago by Nicklas Nordborg

(In [5398]) References #738: Implement file upload as a pure servlet

Removing debug message.

Note: See TracTickets for help on using tickets.