Changeset 1004

Timestamp:

Mar 27, 2009, 7:36:09 PM (12 years ago)

Author:

Jari Häkkinen

Message:

Removed warning suppressions, clean up of code, added missing storeValue of parameter.

File:

• plugins/base2/net.sf.basedb.pluginutilities/trunk/src/net/sf/basedb/plugins/AbstractRunBinaryPlugin.java (modified) (7 diffs)

plugins/base2/net.sf.basedb.pluginutilities/trunk/src/net/sf/basedb/plugins/AbstractRunBinaryPlugin.java

@@ -91 +91 @@
       {
         System.setErr(new PrintStream(debug_outputfile));
-        System.err.println("Initializing super class");
+        System.err.println("Initializing AbstractRunBinaryPlugin");
       }
       catch (IOException e) {
@@ -99 +99 @@
   }
 
-  @SuppressWarnings("unchecked")
+
   public void configure(GuiContext context, Request request, Response response)
   {
@@ -121 +121 @@
         storeValue(job, request, ri.getParameter(CHILD_NAME));
         storeValue(job, request, ri.getParameter(CHILD_DESCRIPTION));
+        if (selectBASconfigure)
+          storeValue(job, request, ri.getParameter(selectBASid));
 
         Job.ExecutionTime execTime = Job.ExecutionTime.SHORT;
@@ -235 +237 @@
           List<BioAssay> assays = sourceBAS.getBioAssays().list(dc);
           PluginParameter<BioAssay> par = new PluginParameter<BioAssay>
-            ( "selectBAS", "Select assays", selectBASdescription,
+            ( selectBASid, "Select assays", selectBASdescription,
               new ItemParameterType<BioAssay>(BioAssay.class, assays.get(0),
                                               true, 0, assays) );
@@ -297 +299 @@
 
 
-  @SuppressWarnings("unchecked")
   public void run(Request request, Response response, ProgressReporter _progress)
   {
-    if (debug_output) System.err.println("run");
+    if (debug_output) System.err.println("ARBP: run");
     progress=_progress;
     DbControl dc=sc.newDbControl();
@@ -310 +311 @@
       if (debug_output)
       {
-        System.err.println("run succesful");
+        System.err.println("ARBP: run successful");
         response.setError("All is okay, just forcing a BASE error.", null);
       }
@@ -384 +385 @@
   protected Boolean selectBASconfigure = false;
   protected String selectBASdescription = null;
+  protected final String selectBASid = "selectBAS";
   protected String subprocess_stdin=null;
   protected String subprocess_stdout=null;