Changeset 3775

Timestamp:

Aug 18, 2010, 2:12:28 PM (13 years ago)

Author:

Gregory Vincic

Message:

Fixes #697. This bug was related to a faulty handling of responses working directly on the servlet response such as redirecting users to external sites. The problem was found in ProteiosAction? which did not check if the response was commited or not before trying to reuse the last action to display an error message.

Location:

trunk/client/servlet/src/org/proteios/action

Files:

• ProteiosAction.java (modified) (1 diff)
• hit/ViewActiveHitExternalId.java (modified) (1 diff)
• hit/ViewHitExternalId.java (modified) (2 diffs)

trunk/client/servlet/src/org/proteios/action/ProteiosAction.java

@@ -328 +328 @@
       runMe();
       if (getForwardTo() == null && getLayout() == null)
-        setForwardTo(actionFactory.getLastAction(getEvent()));
+   {
+    log.debug("Action didn't set forwardTo nor a layout");
+    if(!getResponse().isCommitted())
+    {
+     log.debug("Action faild, let's try to reuse the last action");
+        setForwardTo(actionFactory.getLastAction(getEvent()));
+    }
+   }
     }
     catch (ItemNotFoundException e)

trunk/client/servlet/src/org/proteios/action/hit/ViewActiveHitExternalId.java

@@ -98 +98 @@
        * Get hit id for error message.
        */
-      verifySessionAttributes(ViewActiveHit.VHITID);
       Integer hitId = getSessionAttribute(ViewActiveHit.VHITID);
+   if(hitId!=null) { hitId = getValidInteger(FormFactory.VID); }
+   
       log.debug("hitId = " + hitId);
       /*

trunk/client/servlet/src/org/proteios/action/hit/ViewHitExternalId.java

@@ -29 +29 @@
 
 import org.proteios.action.ProteiosAction;
+import org.proteios.action.ConfigureTableFactory2;
 import org.proteios.core.DbControl;
 import org.proteios.core.Hit;
@@ -84 +85 @@
        */
       setError("Hit[" + hitId + "] - External id is null");
+   setForwardTo(ConfigureTableFactory2.class);
     }
   }