Changeset 3868

Timestamp:

Sep 23, 2010, 9:37:16 AM (13 years ago)

Author:

Gregory Vincic

Message:

Changed ProteiosAction? to debug all parameters and attributes when using getValidXXX methods. Set log4j.logger.org.proteios.action=debug

Location:

trunk/client/servlet

Files:

• conf/log4j.properties.in (modified) (1 diff)
• src/org/proteios/action/ProteiosAction.java (modified) (10 diffs)

trunk/client/servlet/conf/log4j.properties.in

@@ -74 +74 @@
 
 ### Action logger
+# Change this logger to debug during development to display parameters/attributes used 
+# within actions
 log4j.logger.org.proteios.action=warn
 

trunk/client/servlet/src/org/proteios/action/ProteiosAction.java

@@ -501 +501 @@
 
 
-  protected ArrayList<String> toList(String... strings)
-  {
-    ArrayList<String> list = new ArrayList<String>(strings.length);
-    for (String str : strings)
-    {
-      list.add(str);
-    }
-    return list;
-  }
-
-
   /**
    * Stores a valid Boolean for this request.
@@ -696 +685 @@
     {
       String str = getValue(param);
-      log.debug("String[" + key + "=" + str + "]"); // TODO this will actually output passwords in clear text
       value = str;
     }
+    log.debug("String[" + key + "=" + value + "]"); // TODO this will actually output passwords in clear text
     paramValidator.validate(param, value);
     setErrorAttribute(param, "");
@@ -752 +741 @@
     }
     paramValidator.validate(param, value);
+    log.debug("Date[" + key + "=" + value + "]"); 
     return value;
   }
@@ -786 +776 @@
     {
       String str = getValue(param);
-      log.debug("Boolean[" + key + "=" + str + "]");
       value = convert.toBoolean(str);
     }
+    log.debug("Boolean[" + key + "=" + value + "]");
     paramValidator.validate(param, value);
     return value;
@@ -819 +809 @@
     {
       String str = getValue(param);
-      log.debug("Float[" + key + "=" + str + "]");
       value = convert.toFloat(str);
     }
+    log.debug("Float[" + key + "=" + value + "]");
     paramValidator.validate(param, value);
     return value;
@@ -852 +842 @@
     {
       String str = getValue(param);
-      log.debug("Integer[" + key + "=" + str + "]");
       value = convert.toInteger(str);
     }
+    log.debug("Integer[" + key + "=" + value + "]");
     paramValidator.validate(param, value);
     return value;
@@ -895 +885 @@
           for (String str : strings)
           {
-            log
-              .debug("List<Integer>[" + param.getName() + "=" + str + "]");
-            Integer value = convert.toInteger(str);
+              Integer value = convert.toInteger(str);
             paramValidator.validate(param, value);
             valid.add(value);
@@ -908 +896 @@
       }
     }
+  for(Integer i : valid) 
+   {
+      log.debug("List<Integer>[" + param.getName() + "=" + i + "]");
+  }
+
     return valid;
   }
@@ -946 +939 @@
           for (String value : values)
           {
-            log
-              .debug("List<String>[" + param.getName() + "=" + value + "]");
             paramValidator.validate(param, value);
             valid.add(value);
@@ -959 +950 @@
       }
     }
+    for (String v : valid)
+    {
+        log.debug("List<String>[" + param.getName() + "=" + v + "]");
+  }
     return valid;
   }