Opened 15 years ago

Closed 15 years ago

Last modified 10 years ago

#339 closed (fixed)

Enable annotations for extracts

Reported by: Fredrik Levander Owned by: olle
Milestone: Proteios 2.1 Keywords:
Cc:

Description

It should be possible to view and add annotations for extracts, as is currently possible for samples.

Change History (12)

comment:1 Changed 15 years ago by Fredrik Levander

Milestone: Proteios Future ReleaseProteios 2.1

comment:2 Changed 15 years ago by olle

Status: newassigned

Ticket accepted.

comment:3 Changed 15 years ago by olle

severity: 162

Severity changed to 2, as changes needed for Extract.class and LabeledExtract.class in order to add annotations can be based on corresponding code for Sample.class. Similarly, new needed classes can be based on corresponding classes used for adding annotations to Sample items.

comment:4 Changed 15 years ago by olle

(In [2477]) Refs #339. Class/file action/write/AddAnnotation.java in client/servlet/ updated in public method void runMe():

  1. An ItemFactory instance is obtained by calling getItemFactory(dc), instead of always creating a new ItemFactory instance.
  1. A BasicItem item with known id 'id' is obtained by calling factory.getById(Item.valueOf(itemType).getItemClass(), id) instead of Item.valueOf(itemType).getById(dc, id). This removes the need for the core class for the item to have a getById(...) method.
Last edited 12 years ago by olle (previous) (diff)

comment:5 Changed 15 years ago by olle

(In [2479]) Refs #339. Update to allow annotation support for extracts and labeled extracts.

  1. Classes/files action/extract/ViewActiveExtract.java and action/extract/ViewActiveLabeledExtract.java in client/servlet/ updated in protected method void runMe() by adding an annotation form analogously to action/sample/ViewActiveSample.java in client/servlet/.
  1. New classes/files action/extract/AddExtractFile.java and action/extract/AddLabeledExtractFile.java in client/servlet/ based on class/file action/sample/AddSampleFile.java in client/servlet/.
  1. New classes/files action/extract/CreateExtractFile.java and action/extract/CreateLabeledExtractFile.java in client/servlet/ based on class/file action/sample/CreateSampleFile.java in client/servlet/.
Last edited 12 years ago by olle (previous) (diff)

comment:6 Changed 15 years ago by Gregory Vincic

(In [2487]) Refs #339. Fixed bug when saving existing annotations.

comment:7 Changed 15 years ago by Jari Häkkinen

Resolution: fixed
Status: assignedclosed

comment:8 Changed 12 years ago by olle

(In [4158]) Refs #741. Refs #339. Annotation management for biomaterials, i.e. samples, extracts, and labeled extracts, updated with view action for an annotation, that allows the value to be edited, and support for deleting an annotation:

  1. Class/file action/annotation/SaveAnnotation.java in client/servlet/ updated to obtain an action link id from valid parameter VString ForwardField.VPARAM, and forward action to this when it is finished.
  1. Class/file action/annotation/ViewAnnotation.java in client/servlet/ updated to obtain an action link id from valid parameter VString ForwardField.VPARAM, and transfer the value to SaveAnnotation, if the latter action is called.
  1. Class/file action/file/ViewActiveFile.java in client/servlet/ updated to set value of valid parameter VString ForwardField.VPARAM to that of the class itself (in this case ViewActiveFile), when action ViewAction is called.
  1. Class/file action/sample/ViewActiveSample.java in client/servlet/ updated in private method Table createAnnotationsTable(TableFactory tableFactory, ItemQuery<Annotation> annotationQuery) to set view action for annotation value to ViewAnnotation and add tool bar with button coupled to action link to DeleteAnnotations.
  1. Class/file action/extract/ViewActiveExtract.java in client/servlet/ updated to create annotation table using same private method Table createAnnotationsTable(TableFactory tableFactory, ItemQuery<Annotation> annotationQuery) as was used for ViewActiveSample.
  1. Class/file action/extract/ViewActiveLabeledExtract.java in client/servlet/ updated to create annotation table using same private method Table createAnnotationsTable(TableFactory tableFactory, ItemQuery<Annotation> annotationQuery) as was used for ViewActiveSample.

comment:9 Changed 12 years ago by olle

(In [4159]) Refs #741. Refs #339. View action defined for items when listing labeled extracts:

  1. Class/file action/ActionFactory.java in client/servlet/ updated in public synchronized method ActionLink getViewActionLink(AttributeDefinition ad) to set view action for labeled extract items to ViewLabeledExtract.

comment:10 Changed 12 years ago by olle

(In [4161]) Refs #741. Refs #339. Annotation management for biomaterials, i.e. samples, extracts, and labeled extracts, updated with links for associated file items, that leads to the properties form for the file:

  1. Class/file action/sample/ViewActiveSample.java in client/servlet/ updated in private method Table createFileTable(Sample sample) with action link for associated file items. The action link is coupled to action ViewFile, and the file id value is added to valid parameter VInteger FormFactory.VID.
  1. Class/file action/extract/ViewActiveExtract.java in client/servlet/ updated in protected method void runMe() with action link for associated file items. The action link is coupled to action ViewFile, and the file id value is added to valid parameter VInteger FormFactory.VID.
  1. Class/file action/extract/ViewActiveLabeledExtract.java in client/servlet/ updated in protected method void runMe() with action link for associated file items. The action link is coupled to action ViewFile, and the file id value is added to valid parameter VInteger FormFactory.VID.

comment:11 Changed 10 years ago by olle

(In [4456]) Refs #283. Refs #339. Classes/files action/sample/AddSampleFile.java, action/extract/AddExtractFile.java, and action/extract/AddLabeledExtractFile.java in client/servlet/ updated to not crash if no active project has been selected.

Last edited 10 years ago by olle (previous) (diff)

comment:12 Changed 10 years ago by olle

(In [4457]) Refs #283. Refs #339. Classes/files action/sample/CreateSampleFile.java, action/extract/CreateExtractFile.java, and action/extract/CreateLabeledExtractFile.java in client/servlet/ updated to check if file list equals null before calling its isEmpty() method.

Note: See TracTickets for help on using tickets.