Opened 12 years ago

Closed 12 years ago

#727 closed (fixed)

Spectrum File Inspector Extension should be made a Core Extension

Reported by: olle Owned by: olle
Milestone: Proteios SE 2.14.0 Keywords:
Cc:

Description

With increasing importance of spectrum files relative to peak lists imported to the database, external extension for viewing spectrum data in a spectrum file described in wiki Spectrum File Inspector should be made a core extension, i.e. it should be included with a standard Proteios SE installation, without the need to install it separately. A note should be added to the wiki page of the external extension, that it is only needed to install the external extension separately on systems running versions of Proteios SE 2.13.0 or earlier.

In connection with the change to core extension, two updates should also be made:

  1. To comply with the design of newer one-file extensions, if more than one file are selected, an error message should be displayed,

informing the user to select a single file.

  1. In addition to FileContext, the extension should support

FileTypeContext for supported spectrum files.

Change History (8)

comment:1 Changed 12 years ago by olle

Status: newassigned

Ticket accepted.

comment:2 Changed 12 years ago by olle

(In [4041]) Refs #727. Class/file action/file/InspectSpectrumFileExtension.java in client/servlet/ added, and made a core extension in Proteios SE version 2.14.0.

comment:3 Changed 12 years ago by olle

(In 2) Proteios SE extension wiki page Spectrum File Inspector updated in section Documentation with note that active development of external extension has terminated.

comment:4 Changed 12 years ago by olle

(In [4042]) Refs #727. Class/file action/file/InspectSpectrumFileExtension.java in client/servlet/ updated:

  1. Protected method void runMe() updated to display an error

message if more than one file has been selected.

comment:5 Changed 12 years ago by olle

(In [4043]) Refs #727. Class/file action/file/InspectSpectrumFileExtension.java in client/servlet/ updated by removal of unused import.

comment:6 Changed 12 years ago by olle

Design note.

Supported file types are defined in class/file action/file/SpectrumFileReaderFactory.java in client/servlet/ in public method PeakListFileInterface fetchPeakListFileReader(File file, boolean useTitle).

comment:7 Changed 12 years ago by olle

(In [4044]) Refs #727. Class/file action/file/InspectSpectrumFileExtension.java in client/servlet/ updated:

  1. Public method List<Context> listContexts() updated to call new

private convenience method List<Context> addFileTypeContext(List<Context> contextList, String fileTypeStr) to update conetext list with file type extensions for file types supported in public method PeakListFileInterface fetchPeakListFileReader(File file, boolean useTitle) in class/file action/file/SpectrumFileReaderFactory.java in client/servlet/.

  1. New private convenience method

List<Context> addFileTypeContext(List<Context> contextList, String fileTypeStr) added. It updates a context list by adding a file type context.

comment:8 Changed 12 years ago by olle

Resolution: fixed
Status: assignedclosed

The ticket is closed, as the desired functionality has been added. Should problems with the current solution appear, this ticket may be reopened, or a new ticket created.

Note: See TracTickets for help on using tickets.