Changeset 1205

Timestamp:

Oct 6, 2010, 1:31:51 AM (13 years ago)

Author:

Peter Johansson

Message:

avoid copying. use max_element instead of back() so plot_summary also can be used in sub-classes for which this is not equivalent (see impl max_element)

File:

• trunk/lib/Stats.cc (modified) (1 diff)

trunk/lib/Stats.cc

@@ -511 +511 @@
   {
     Graph gp(filename+"."+format, format);
-    // FIXME: why not const&
-    SumVector total = get_vector(total_stats(), "all");
-    double yrange_max=1.03*total.back()+1;
+    const SumVector& total = get_vector(total_stats(), "all");
+    double yrange_max=1.03*max_element(total)+1;
     gp.ymax(yrange_max);
     
-    // FIXME: why not const&
-    SumVector x(get_vector(code_stats(), "all"));
+    const SumVector& x(get_vector(code_stats(), "all"));
     gp.current_color(255,255,0);
     gp.plot(x, "code", x.back());
 
-    x = get_vector(comment_or_copy_stats(), "all");
+    const SumVector& y = get_vector(comment_or_copy_stats(), "all");
     gp.current_color(0,0,255);
-    gp.plot(x, "comment", x.back());
-
-    x = get_vector(other_stats(), "all");
+    gp.plot(y, "comment", y.back());
+
+    const SumVector& z = get_vector(comment_or_copy_stats(), "all");
     gp.current_color(0,255,0);
-    gp.plot(x, "other", x.back());
+    gp.plot(z, "other", z.back());
 
     gp.current_color(255,0,0);