Changeset 1217

Timestamp:

Oct 10, 2010, 2:46:37 AM (13 years ago)

Author:

Peter Johansson

Message:

update docs and remove third argument in cleanup_failed_init since the bool was not used in function. refs #371

Location:

trunk/lib

Files:

• SVN.cc (modified) (2 diffs)
• SVN.h (modified) (2 diffs)

trunk/lib/SVN.cc

@@ -132 +132 @@
                               context_->cancel_baton, pool_))){
       if (err->apr_err == SVN_ERR_WC_NOT_DIRECTORY)
-        cleanup_failed_init(err, std::string(err->message), true);
+        cleanup_failed_init(err, std::string(err->message));
       cleanup_failed_init(err, "SVN: svn_wc_adm_open3 failed");
     }
@@ -173 +173 @@
 
 
-  void SVN::cleanup_failed_init(svn_error_t *err, const std::string& message,
-                                bool mute)
+  void SVN::cleanup_failed_init(svn_error_t *err, const std::string& message)
   {
     assert(message.size()); // compatible with r1213

trunk/lib/SVN.h

@@ -243 +243 @@
        @brief Free resources when svn API calls fail.
 
-       This function will write an error message to stdout, free \a
-       err and \a pool resources. If \a err or \a pool are a NULL
-       pointers the function will do nothing with these resources. If
-       \a mute is true, no error message is written.
-
-       cleanup will throw a SVNException if \a message has
-       length>0. The default bahaviour is to free resources and return
-       normally.
+       This function will free \a pool resources and throw an
+       exception holding the \a message. If mute is false, the thrown
+       exception also contains \a err.
+
+       \throw cleanup will throw a SVNException
 
        @see SVNException
@@ -267 +264 @@
        @see SVNException
     */
-    void cleanup_failed_init(svn_error_t *err, const std::string& message,
-                             bool mute=false);
+    void cleanup_failed_init(svn_error_t *err, const std::string& message);
 
     static SVN* instance_;