Changeset 1489

Timestamp:

Aug 21, 2012, 5:11:20 AM (9 years ago)

Author:

Peter Johansson

Message:

fixes #515. avoid accessing zero-sized vector; reported by Vedran Ljubovic.

Location:

branches/0.9-stable

Files:

• THANKS (modified) (1 diff)
• lib/Stats.cc (modified) (4 diffs)

branches/0.9-stable/THANKS

@@ -22 +22 @@
 is licensed under GNU GPL <http://www.gnu.org/licenses/>.
 
+Vedran Ljubovic for reporting bug #515
+
 -----------------------------------------------------------------------
 {{{

branches/0.9-stable/lib/Stats.cc

@@ -4 +4 @@
   Copyright (C) 2005 Peter Johansson
   Copyright (C) 2006, 2007, 2008, 2009 Jari Häkkinen, Peter Johansson
-  Copyright (C) 2010 Peter Johansson
+  Copyright (C) 2010, 2012 Peter Johansson
 
   This file is part of svndigest, http://dev.thep.lu.se/svndigest
@@ -242 +242 @@
     if (iter==m.end() || iter->second.empty()) 
       return 0;
+    assert(iter->second.size());
     return iter->second.back();
   }
@@ -476 +477 @@
       Colors::instance().get_color(label, r,g,b);
       gp.current_color(r,g,b);
-      gp.plot(others, label, others.back());
+      gp.plot(others, label, others.size() ? others.back() : 0);
     }
     for ( ; i!=end; ++i) {
@@ -513 +514 @@
     const SumVector& x(get_vector(code_stats(), "all"));
     gp.current_color(255,255,0);
+    assert(x.size());
     gp.plot(x, "code", x.back());
 
     const SumVector& y = get_vector(comment_or_copy_stats(), "all");
     gp.current_color(0,0,255);
+    assert(y.size());
     gp.plot(y, "comment", y.back());
 
     const SumVector& z = get_vector(other_stats(), "all");
     gp.current_color(0,255,0);
+    assert(z.size());
     gp.plot(z, "other", z.back());
 
     gp.current_color(255,0,0);
+    assert(total.size());
     gp.plot(total, "total", total.back());
   }