Changeset 16 for trunk/lib

Timestamp:

Dec 30, 2005, 6:30:51 PM (17 years ago)

Author:

Peter Johansson

Message:

merged Node::info() and Node::subversion_controlled()

Location:

trunk/lib

Files:

• Directory.cc (modified) (1 diff)
• File.cc (modified) (1 diff)
• Node.cc (modified) (3 diffs)
• Node.h (modified) (2 diffs)

trunk/lib/Directory.cc

@@ -60 +60 @@
   const Stats& Directory::parse(void)
   {
-    // calling svn info;
-    info();
     stats_.reset();
 

trunk/lib/File.cc

@@ -24 +24 @@
   const Stats& File::parse(void)
   {
-    // calling svn info 
-    info();
     stats_.reset();
     if (binary_){

trunk/lib/Node.cc

@@ -11 +11 @@
 namespace svnstat{
 
-  bool Node::info()
+  bool Node::subversion_controlled(void) 
   {
     std::string system_call = "svn info " + path_ + " > svnstat.tmp";
@@ -19 +19 @@
       return false;
     }
+    std::cerr << "Ok: svn info " << path_ << std::endl;     
     std::ifstream is("svnstat.tmp");
     std::string line;
@@ -36 +37 @@
   }
 
-  bool Node::subversion_controlled(void) const {
-    std::string system_call = "svn info " + path_;
-    int system_return = system(system_call.c_str());
-    if (system_return){
-      std::cerr << "Error: svn info " << path_ << std::endl;     
-      return false;
-    }
-    std::cerr << "Alright: svn info " << path_ << std::endl;     
-
-    return true;
-  }
-
+  
 }} // end of namespace svnstat and namespace theplu

trunk/lib/Node.h

@@ -20 +20 @@
     /// @brief Constructor 
     /// 
-    inline Node(const std::string& path) : path_(path) { info(); }
+    inline Node(const std::string& path) : path_(path) {}
 
     ///
@@ -38 +38 @@
 
     ///
-    /// Check if the node is under subversion control.
+    /// Check if the node is under subversion control. If node
+    /// is under subversion control, information about node is 
+    /// parsed from the 'svn info' output.
+    /// 
     ///
     /// @return True if subversion controlled, false otherwise.
     ///
-    bool subversion_controlled(void) const;
+    bool subversion_controlled(void);
 
   protected:
-    ///
-    /// @brief performing svn info and parsing the info.
-    ///
-    /// @return true if parsing succesful
-    ///
-    bool info(void);
-
     std::string author_;
     std::string path_;