Changeset 44 for trunk/lib

Timestamp:

Jan 13, 2006, 7:38:16 PM (16 years ago)

Author:

Jari Häkkinen

Message:

Removed unused #includes.
Fixed doxygen tag spelling errors.
Changed png filename generation.

Location:

trunk/lib

Files:

• Stats.cc (modified) (4 diffs)
• Stats.h (modified) (2 diffs)

trunk/lib/Stats.cc

@@ -5 +5 @@
 #include "utility.h"
 
-#include <cstdio>
-#include <fstream>
-
 #include <algorithm>
 #include <map>
@@ -13 +10 @@
 #include <sstream>
 #include <string>
+#include <unistd.h>
 #include <utility>
 #include <vector>
-
-#include <iostream>
 
 namespace theplu{
@@ -69 +65 @@
   std::string Stats::plot(void) const
   {
-    char name[]="svnstatXXXXXX";
-    if (!strlen(mktemp(name))) {
-      std::cerr << "Failed to get unique filename: " << name << std::endl;
-      exit(-1);
-    }
-    std::string cmd=std::string("set term png; set output '")+name+".png'";
+    char name[]="svnstat_XXXXXX.png";
+    if (mkstemps(name,4)==-1)
+      throw std::runtime_error(std::string("Failed to get unique filename: ") +
+                               name);
+    std::string cmd=std::string("set term png; set output '")+name+"'";
     gnuplot_pipe_.command(cmd);
     gnuplot_pipe_.command("set key left Left reverse");
@@ -95 +90 @@
     gnuplot_pipe_.command(cmd);
     gnuplot_pipe_.command("replot");
-    return std::string(name)+".png";
-  }
-
-  void Stats::print(std::ostream& os) const
-  {
-    os << "<p><img src='" << plot() << "' alt='[svnstat plot]' border=0></p>\n";
+    return name;
   }
 

trunk/lib/Stats.h

@@ -5 +5 @@
 
 #include <map>
+#include <ostream>
 #include <string>
 #include <vector>
@@ -30 +31 @@
 
     ///
-    /// @bief print statistics
+    /// @brief Print statistics
     ///
-    void print(std::ostream&) const;
+    void inline print(std::ostream& s) const
+    { s << "<p><img src='" << plot() << "' alt='[plot]' border=0></p>\n"; }
 
     ///