Changeset 998 for branches/0.7-stable

Timestamp:

Jan 1, 2010, 11:54:32 PM (13 years ago)

Author:

Peter Johansson

Message:

Fixes #434. Authors are now ignored in the plot if and only if plot
would be y=0.

Location:

branches/0.7-stable/lib

Files:

• AddStats.cc (modified) (1 diff)
• AddStats.h (modified) (1 diff)
• BlameStats.cc (modified) (1 diff)
• BlameStats.h (modified) (1 diff)
• Stats.cc (modified) (2 diffs)
• Stats.h (modified) (1 diff)
• copyright_year.cc (modified) (1 diff)

branches/0.7-stable/lib/AddStats.cc

@@ -77 +77 @@
 
 
+  unsigned int AddStats::max_element(const std::vector<unsigned int>& v) const 
+  {
+    assert(v.size());
+    return v.back();
+  }
+
+
 }} // end of namespace svndigest and namespace theplu

branches/0.7-stable/lib/AddStats.h

@@ -44 +44 @@
   private:
     void do_parse(const std::string&, svn_revnum_t);
+    unsigned int max_element(const std::vector<unsigned int>&) const; 
 
   };

branches/0.7-stable/lib/BlameStats.cc

@@ -118 +118 @@
 
 
+  unsigned int BlameStats::max_element(const std::vector<unsigned int>& v) const 
+  {
+    assert(v.size());
+    return v.back();
+  }
+
 }} // end of namespace svndigest and namespace theplu

branches/0.7-stable/lib/BlameStats.h

@@ -45 +45 @@
     void do_parse(const std::string&, svn_revnum_t);
     void fill_in(Author2Vector&, svn_revnum_t rev);
+    unsigned int max_element(const std::vector<unsigned int>&) const; 
 
   };

branches/0.7-stable/lib/Stats.cc

@@ -332 +332 @@
       }
     }
+  }
+
+
+  unsigned int Stats::max_element(const std::vector<unsigned int>& vec) const
+  {
+    return *std::max_element(vec.begin(), vec.end());
   }
 
@@ -380 +386 @@
     for (std::set<std::string>::const_iterator i=authors_.begin(); 
          i != authors_.end(); ++i) {
-      if (lines(*i)) {
-        assert(stat->find(*i)!=stat->end());
-        author_cont.push_back(std::make_pair(*i,get_vector(*stat,*i)));
+      assert(stat->find(*i)!=stat->end());
+      const std::vector<unsigned int>& vec = get_vector(*stat,*i);
+      if (max_element(vec)) {
+        author_cont.push_back(std::make_pair(*i,vec));
       }
     }

branches/0.7-stable/lib/Stats.h

@@ -233 +233 @@
     unsigned int get_back(const Author2Vector&, std::string user) const;
     void load(std::istream& is, Author2Vector& m);
+    /**
+       Finds the largets element by iterating through the entire
+       vector. Inherited classes should implement their own version
+       when it is possible to get the largest element in faster than
+       in linear time.
+
+       \return the largest largest element in \a v. 
+    */
+    virtual unsigned int max_element(const std::vector<unsigned int>& v) const; 
+
     void print(std::ostream& os, const Author2Vector& m) const;
 

branches/0.7-stable/lib/copyright_year.cc

@@ -29 +29 @@
   std::string svn_year(void)
   {
-    return "2009";
+    return "2010";
   }