Opened 14 years ago

Closed 14 years ago

#188 closed defect (fixed)

trac-links are truncated

Reported by: Peter Johansson Owned by: Peter Johansson
Priority: major Milestone: 0.6
Component: output Version: trunk
Keywords: Cc:

Description

messages in recent log is truncated. The truncation is done before the Trac class parses for trac-links. This is bad because the links becomes incorrect. See revision revision at

http://www.thep.lu.se/~jari/svndigest/svndigest/

Trancation must be done afterwards. Optimally anchors should be truncated but only the visible part...

Change History (5)

comment:1 Changed 14 years ago by Peter Johansson

I have come up with three solutions to this issue. If the entire anchor does not fit

  • truncate after the anchor: some message example...
  • truncate in the visible part of the anchor: some message exam...
  • truncate before the anchor: some message ...

If you have an opinion on which you think is the best way, speak up!

comment:2 Changed 14 years ago by Jari Häkkinen

How are the log lines truncated now? After a constant number of characters? i am speaking even though I have no real opinion. What is the easiest solution? I like the second example. Either way you can always klick on the revision link and get the full log message.

comment:3 Changed 14 years ago by Peter Johansson

At the time being it is done as follows: First the html code is generated and then the truncation is done, i.e., we cutoff in the middle of the anchor.

The different options would be implemented in smimilar ways so there is no real difference in sense of easy/difficult.

comment:4 Changed 14 years ago by Peter Johansson

Status: newassigned

comment:5 Changed 14 years ago by Peter Johansson

Resolution: fixed
Status: assignedclosed

(In [317]) fixing truncation issue in log message. fixes #188

Note: See TracTickets for help on using tickets.