assertion when running on svm_ensemble repo

[Peter Johansson]

Core dump and following verbose msg

Done parsing parameters
Initializing SVN singleton.
Checking target directory
Acquiring repository information
Building directory tree
Parsing directory tree
Parsing /home/kafka/peter/projects/pristine/ensemble/data/README
Parsing /home/kafka/peter/projects/pristine/ensemble/data/golub_all_aml_targets.txt
svndigest: Parser.cc:43: theplu::svndigest::Parser::Parser(std::string): Assertion `is.good()' failed.
Aborted (core dumped)

README is empty, which might be related to this problem.

[Peter Johansson]

The problem is that golub_all_aml_targets.txt is a symbolic link, in fact a broken symbolic link.

What are the specifications for symbolic links? One line or zero lines. In any case, there is no need to parse symbolic links. Neither should we parse binary files or files having property svndigest:ignore.

[Peter Johansson]

The control for ignoring binary and svndigest:ignore files are perfromed using the ignore function in Node.h (source:trunk/lib/Node.h@358#L107​). This function is called in Directory::parse, source:trunk/lib/Directory.cc@358#L129​, to avoid parsing these files.

What about symbolic links then? There is a cryptical comment here source:trunk/lib/Stats.cc@358#L152​. If the parser (container of line types) is empty, we interpret that file as a one-liner (of type other). Note, this means also empty normal files are interpreted as one-liners!

Moreover, I cannot find any code making symbolic links to not be parsed? Are they really treated as a one-liner? Is there any example of a symbolic link in any available repository? If not, I guess we should add a symbolic link to the test repository.

[Peter Johansson]

NOTE: I will add a symbolic link in test repository. Do not touch the test repo until this is finished.

[Peter Johansson]

(In [359]) adding symbolic link refs #213

[Peter Johansson]

Ok, that test shows that a symbolic link indeed is counted as a one-liner.

[Peter Johansson]

(In [361]) made links be counted as zero-liners. fixes #213