Opened 16 years ago

Closed 15 years ago

#270 closed defect (fixed)

Change definition of what is code

Reported by: Peter Johansson Owned by: Peter Johansson
Priority: minor Milestone: svndigest 0.7
Component: statistics Version: 0.6.2
Keywords: Cc:

Description

At time being the definition is

If a line contains alphanumeric characters being outside comment blocks, the line is considered to be code.

I think we should change to

If a line contains visible characters being outside comment blocks, the line is considered to be code. This implies we accept characters such as '{', '(' etc as code.

For comments though, I still think a comment should contain an alphanumerical character.

Change History (3)

comment:1 Changed 16 years ago by Peter Johansson

Resolution: → fixed
Status: new → closed

Fixed in [505]

comment:2 Changed 15 years ago by Peter Johansson

Resolution: fixed
Status: closed → reopened
Type: task → defect

Not correctly implemented. See in test dir bin/svndigest.cc on line 23: */ is labeled as code but should be empty.

comment:3 Changed 15 years ago by Peter Johansson

Resolution: → fixed
Status: reopened → closed

fixed in [506]

Note: See TracTickets for help on using tickets.