Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#272 closed defect (fixed)

possibly double counting in main (sometimes)

Reported by: Peter Johansson Owned by: Peter Johansson
Priority: trivial Milestone: 0.6.4
Component: core Version: trunk
Keywords: Cc:

Description

approximately at line 143 in svndigest.cc:

if (option->verbose())
    std::cout << "Parsing directory tree" << std::endl;
Stats stats(option->root());
stats+=tree->parse(option->verbose())

what is the line Stats stats(option->root()); doing there. Actually what is that constructor doing. I suspect if option->root() is a directory stats will be empty, and else I guess stats will not behave as expected but doubling everything.

Change History (2)

comment:1 Changed 16 years ago by Peter Johansson

Resolution: fixed
Status: newclosed

Fixed in 0.6 branch is [486] and in trunk it was fixed in [487].

comment:2 Changed 16 years ago by Jari Häkkinen

This will cause trouble in merging 0.6.4 into the trunk. We have to make sure that the change isn't removed at merge.

Note: See TracTickets for help on using tickets.