Opened 13 years ago

Closed 13 years ago

#295 closed task (fixed)

Remove configure option --enable-wctests

Reported by: Peter Johansson Owned by: Peter Johansson
Priority: major Milestone: svndigest 0.7
Component: build Version: trunk
Keywords: Cc:

Description (last modified by Peter Johansson)

As of r540 there is an automatic detection of whether a svn working copy exists (in order to know whether we should generate revision and copyright info from svn or accept the file distributed).

The variable used for this could very well be used in test directory as well, and thereby remove the option from configure. This implies that one could no longer choose not to activate all tests, but that is not a good (enough) reason to keep redundancy...

Change History (4)

comment:1 Changed 13 years ago by Peter Johansson

Description: modified (diff)

comment:2 in reply to:  description Changed 13 years ago by Jari Häkkinen

Replying to peter:

As of r540 there is an automatic detection of whether a svn working copy exists (in order to know whether we should generate revision and copyright info from svn or accept the file distributed).

I am not sure what is meant above. There is some file that is distributed, is this the source package with no svn information or is there some revision/copyright file in a distributed source package?

The variable used for this could very well be used in test directory as well, and thereby remove the option from configure. This implies that one could no longer choose not to activate all tests, but that is not a good (enough) reason to keep redundancy...

If the variable is useful to trigger proper test in a svn WC and in a downloaded package then there is no reason to keep the configure variable. Tests should not be optional, the configure variable was a kludge.

comment:3 Changed 13 years ago by Peter Johansson

Ok, to clarify. There is now a test in configure that do two things. First it checks if svnversion is around. svnversion is distributed along with subversion and should therefore be around if subversion is available. Second 'svnversion .' is issued. If '.' is not a svn wc "exported" is returned.

If svnversion is around and returned string from 'svnversion .' is not "exported" a variable HAVE_SVN_WC is set to true.

comment:4 Changed 13 years ago by Peter Johansson

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.