Opened 13 years ago

Closed 13 years ago

#341 closed defect (fixed)

Erroneous creation of test files?

Reported by: Jari Häkkinen Owned by: Peter Johansson
Priority: major Milestone: svndigest 0.7
Component: build Version: trunk
Keywords: Cc:

Description

Should files test/test_repo.sh and test/check_repo_status.sh be created even if no test repo is available or if

m4_define([SVNDIGEST_DEV_BUILD], [false])

is selected in build_support/version.m4?

Change History (2)

comment:1 Changed 13 years ago by Peter Johansson

Status: newassigned

I start with how I think it should work. The tests test/test_repo.sh and test/check_repo_status.sh should be created if there is a wc available, which is reflected by shell variable $wc_found. This is regardless of VERSION number and SVNDIGEST_DEV_BUILD. But note that if you have no wc (i.e. you are building from a tarball) then SVNDIGEST_DEV_BUILD should be set to false.

Now to the errors. The fact is that AC_CONFIG_FILES are malplaced leading to that the tests are created if wc_found!=yes and info_found!=no. The reason that this still worked is because there is a rule in the Makefile how to create the tests, so the tests are created when needed.

comment:2 Changed 13 years ago by Peter Johansson

Resolution: fixed
Status: assignedclosed

fixed in [672]

Note: See TracTickets for help on using tickets.