Opened 15 years ago
Closed 15 years ago
#343 closed task (fixed)
Invalid Directory
| Reported by: | Peter Johansson | Owned by: | Peter Johansson |
|---|---|---|---|
| Priority: | major | Milestone: | svndigest 0.6.6 |
| Component: | core | Version: | 0.6.5 |
| Keywords: | Cc: |
Description
related to ticket:342
If the node in --target that should be removed is either a file or lacks read permission, the deletion fails. Later chdir fails with error message Invalid Directory: Foo, and svndigest writes the output in current directory instead.
Change History (5)
comment:1 Changed 15 years ago by
| Version: | trunk → 0.6.5 |
|---|
comment:2 Changed 15 years ago by
comment:4 Changed 15 years ago by
| Owner: | changed from Jari Häkkinen to Peter Johansson |
|---|---|
| Status: | new → assigned |
comment:5 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [680]) refs #342 and #343. I think this fixes the issue but need to test it (and perhaps add tests) to be sure. I changed rmdirhier to also work on non-dirs. The name, rmdirhier, is perhaps not so descriptive anymore but I prefered changing that function rather than duplicating imilar code elsewhere. I also changed the behavior of rmdirhier in that links are no longer followed but only removed, i.e., a symlink pointing to a dir is only deleted (without deleting the daughter nodes).