Opened 13 years ago

Closed 13 years ago

#462 closed task (wontfix)

specialize log function

Reported by: Peter Johansson Owned by: Jari Häkkinen
Priority: major Milestone:
Component: core Version: trunk
Keywords: Cc:


Most of the time when we call log we are only interested in the dates or in the revs; yet we copy all the information, including log msg, into the log container. I think we should specialize this into having one log function for dates, one for revs, and one full (the current one).

Change History (2)

comment:1 Changed 13 years ago by Jari Häkkinen

The log calls are expensive (at least the way they are implemented in svndigest). Specializing and consequently calling log several times may be inefficient.

comment:2 Changed 13 years ago by Peter Johansson

Milestone: svndigest 0.x+
Resolution: wontfix
Status: newclosed

I don't think it would be many extra calls (I would guess only one), but I haven't looked carefully. OTOH, I agree with you that the cost for svndigest is rarely cpu but most often bandwidth to the repository and consequently this kind of optimizing seems like a typical case of the Pareto principle. I was thinking about lowering the priority but with your comment, I think I close this.

Note: See TracTickets for help on using tickets.