Opened 12 years ago

Closed 12 years ago

#485 closed defect (fixed)

wrong date for end point in plot in BASE

Reported by: Peter Johansson Owned by: Peter Johansson
Priority: major Milestone: svndigest 0.9
Component: output Version: trunk
Keywords: Cc:

Description

Seems like all the plots for BASE project has the same problem

​http://cbbp.thep.lu.se/~jari/svndigest/base/blame/all/code/index.html

that the last point of the curve gets the wrong date. I suspect the date becomes 0 (i.e. 1970-...)

These plots were using svndigest r1265

I don't see the same problem on the test repo with r1270, but I don't think that is per revision but rather there is something with the base repo.

Change History (5)

comment:1 Changed 12 years ago by Peter Johansson

Status: new → assigned

comment:2 Changed 12 years ago by Peter Johansson

(In [1272]) refs #485

comment:3 Changed 12 years ago by Jari Häkkinen

(In [1274]) Addresses #485.

comment:4 Changed 12 years ago by Jari Häkkinen

(In [1275]) Addresses #485. Take care of the case when revisions numbers are used for xaxis rather than dates.

comment:5 Changed 12 years ago by Peter Johansson

Resolution: → fixed
Status: assigned → closed

(In [1276]) Let Graph class hold information about last point (rev_max_) rather than defining via the size of Vector. Not resizing the Vectors means we can avoid some copying in Stats class. But it also means we need to handle the case of empty Vector in Stats::max_element. Made the function Node::svn_info(void) public. In svndigest.cc set rev_min also when not using dates as well as setting the new static variable rev_max. closes #485

Note: See TracTickets for help on using tickets.