Changeset 1618 for trunk

Timestamp:

Nov 6, 2008, 4:58:08 PM (14 years ago)

Author:

Peter

Message:

increasing n and setting margin in a more statistically correct way. The arbitrary constant, 10, is chosen to make it very unlikely to fail by chance.

File:

• trunk/test/kolmogorov_smirnov_test.cc (modified) (2 diffs)

trunk/test/kolmogorov_smirnov_test.cc

@@ -78 +78 @@
   double p = ks.p_value(n);
   double p_correct = 2.0/11.0;
-  double margin = 5*std::sqrt(n*p_correct)/n;
+  double margin = 10*std::sqrt(p_correct*(1-p_correct)/n);
   if (p>p_correct+margin || p<p_correct-margin) {
     suite.err() << "Error: p-value: " << p << "\n"
@@ -95 +95 @@
     ks.add(i+0.5, i<2);
   suite.add(suite.equal(ks.score(), 1.0));
-  size_t n=1000;
+  size_t n=100000;
   double p = ks.p_value(n);
   double p_correct = 0.2;
-  double margin=10*std::sqrt(n*p_correct)/n;
+  double margin=10*std::sqrt(p_correct*(1-p_correct)/n);
   if (std::abs(p-p_correct)>margin) {
     suite.add(false);