Changeset 2496

Timestamp:

Jun 22, 2011, 4:31:25 PM (10 years ago)

Author:

Peter

Message:

benjamini-hochberg: avoid crash when input is empty range. Speed-up when iterator is not random access.

File:

• trunk/yat/statistics/utility.h (modified) (2 diffs)

trunk/yat/statistics/utility.h

@@ -41 +41 @@
 #include <algorithm>
 #include <cmath>
+#include <iterator>
 #include <stdexcept>
 #include <vector>
@@ -231 +232 @@
     BOOST_CONCEPT_ASSERT((Mutable_BidirectionalIterator<BidirectionalIterator2>));
     size_t n = std::distance(first, last);
-    std::advance(result, n);
-    --result;
-    std::advance(first, n);
+    if (!n)
+      return;
+    std::advance(result, n-1);
+    first = last;
     --first;
     size_t rank = n;