Changeset 759 for trunk/test

Timestamp:

Feb 19, 2007, 8:41:25 PM (16 years ago)

Author:

Jari Häkkinen

Message:

Fixes #171 and addresses #2. A few more GSL_error exceptions. Removed Jari comments.

Location:

trunk/test

Files:

• nni_test.cc (modified) (3 diffs)
• regression_test.cc (modified) (1 diff)
• svd_test.cc (modified) (1 diff)

trunk/test/nni_test.cc

@@ -70 +70 @@
   utility::matrix control(control_stream);
   control-=knni.imputed_data();
-  // Jari, should we use GSL defined round off errors? Anyway, the
-  // hardcoded number below should be changed.
   double error_bound = 5e-13;
   for (unsigned int i=0; i<control.rows(); i++)
@@ -106 +104 @@
   for (unsigned int i=0; i<control.rows(); i++)
     for (unsigned int j=0; j<control.columns(); j++)
-      // Jari, should we use GSL defined round off errors? Anyway, the
-      // hardcoded number below should be changed.
       if (fabs(control(i,j))>error_bound) {
         if (print)
@@ -139 +135 @@
   for (unsigned int i=0; i<control.rows(); i++)
     for (unsigned int j=0; j<control.columns(); j++)
-      // Jari, should we use GSL defined round off errors? Anyway, the
-      // hardcoded number below should be changed.
       if (fabs(control(i,j))>error_bound) {
         if (print)

trunk/test/regression_test.cc

@@ -219 +219 @@
     utility::vector fit=polynomialfit.fit_parameters();
     if (fabs(fit[0]-1.012229646706 + fit[1]-0.012561322528 +
-             fit[2]+1.159674470130)>1e-11) {  // Jari, fix number!
+             fit[2]+1.159674470130)>1e-11) {
       *error << "regression_Polynomial: cannot reproduce fit." << std::endl;
       ok=false;

trunk/test/svd_test.cc

@@ -42 +42 @@
 bool test(size_t m, size_t n, utility::SVD::SVDalgorithm algo)
 {
-  // accepted error, Jari: should be picked up from GSL
-  double MAXTOL=1e-13;
+  double MAXTOL=1e-13; // accepted error
 
   // initialise a random test-matrix