#202 closed enhancement (fixed)
Matrix View
Reported by: | Jari Häkkinen | Owned by: | Peter |
---|---|---|---|
Priority: | major | Milestone: | yat 0.20 |
Component: | utility | Version: | trunk |
Keywords: | Cc: |
Description
Change History (20)
comment:1 Changed 15 years ago by
Summary: | utility::matrix has internal support for matrix views but there is no interface to create a matrix view → utility::matrix has internal support for const matrix views but there is no interface to create a const matrix view |
---|
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
Related to this is that the following constructor should be removed from interface. It is a flaw to allow thos constructor because it creates a huge hole against const correctness.
vector(const vector& v, size_t offset, size_t n, size_t stride=1);
comment:4 Changed 13 years ago by
Type: | defect → enhancement |
---|
comment:5 Changed 8 months ago by
Owner: | changed from Jari Häkkinen to Peter |
---|---|
Status: | new → accepted |
Summary: | utility::matrix has internal support for const matrix views but there is no interface to create a const matrix view → Matrix View |
It's time to implement this. Follow the same class hierarchy as Vector classes.
comment:6 Changed 8 months ago by
Milestone: | yat 0.x+ → yat 0.20 |
---|
comment:10 Changed 6 months ago by
There is a pure virtual function in Multivariate
virtual void fit(const utility::Matrix& x, const utility::VectorBase& y)=0;
where we would like to change to take MatrixBase with the downside that it'd break all classes inheriting from this interface class. A way to introduce MatrixBase? is to introduce a virtual fit2 class taking MatrixBase, for which the default implementation is to copy to a Matrix and call fit function.
There is a test in matrix_test.cc that must be fixed when resolving this ticket. Look for a comment with ticket:202 in the code, this will point you to the code that needs to be changed.