Opened 13 years ago

Closed 13 years ago

#300 closed defect (fixed)

PCA sorts eigen vectors using N*N algo

Reported by: Peter Owned by: Peter
Priority: minor Milestone: yat 0.5
Component: utility Version:
Keywords: Cc:


Why not use std::sort here? Eigen vectors are sorted in order of corresponding eigen value. This could be solved by having a pair<eigenvalue, eigenvector>

Change History (5)

comment:1 Changed 13 years ago by Jari Häkkinen

Milestone: yat 0.5yat 0.x+

comment:2 Changed 13 years ago by Peter

As I understand the GSL manual, the single values are always ordered in non-increasing order. We want our eigenvalues to ordered in a non-decreasing order. Instead of doing a complete sort, the values could simply be reversed (scaling N rather N*N).

comment:3 Changed 13 years ago by Peter

We want the eigenvalues to be ordered in a non-increasing order just like what SVD is returning.

Sorry for the confusion.

comment:4 Changed 13 years ago by Peter

Milestone: yat 0.x+yat 0.5
Owner: changed from Jari Häkkinen to Peter
Status: newassigned

comment:5 Changed 13 years ago by Peter

Resolution: fixed
Status: assignedclosed

(In [1476]) fixes #300 - I simply removed the sorting

Note: See TracTickets for help on using tickets.